From owner-freebsd-ports@FreeBSD.ORG Sun Feb 12 20:48:37 2012 Return-Path: Delivered-To: freebsd-ports@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E281F1065672 for ; Sun, 12 Feb 2012 20:48:37 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id 308B88FC18 for ; Sun, 12 Feb 2012 20:48:36 +0000 (UTC) Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id WAA11197; Sun, 12 Feb 2012 22:48:31 +0200 (EET) (envelope-from avg@FreeBSD.org) Received: from localhost ([127.0.0.1]) by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1RwgLX-000GYM-9Q; Sun, 12 Feb 2012 22:48:31 +0200 Message-ID: <4F382592.3060600@FreeBSD.org> Date: Sun, 12 Feb 2012 22:48:18 +0200 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:10.0) Gecko/20120202 Thunderbird/10.0 MIME-Version: 1.0 To: Steve Kargl References: <20120212193927.GA86426@troutmask.apl.washington.edu> <20120212201624.GA86650@troutmask.apl.washington.edu> <4F3820AD.4090702@FreeBSD.org> <20120212204118.GA86775@troutmask.apl.washington.edu> In-Reply-To: <20120212204118.GA86775@troutmask.apl.washington.edu> X-Enigmail-Version: 1.3.5 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: freebsd-ports@FreeBSD.org, Chris Rees Subject: Re: Please test your commits X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Feb 2012 20:48:38 -0000 on 12/02/2012 22:41 Steve Kargl said the following: > On Sun, Feb 12, 2012 at 10:27:25PM +0200, Andriy Gapon wrote: >> on 12/02/2012 22:16 Steve Kargl said the following: >>> You seem to have the faulty belief that this is the first occurence >>> of this type of issue? >> >> So instead of proper report to the port's maintainer (including description of >> your environment, possibly full build log, etc), possibly with a CC here, you >> decided to vent out here... >> >> Is there any requirement that people do the former and not the latter? :-) >> > > I'm not venting. I'm simply requesting that all committers > test the code that they intend to commit. It is quite > clear that this particular commit was not tested. > > The environment is irrelevant because malloc.h was poisoned > 10 years, 3 months ago. As to a full build log, the > necessary information was included in my original email. > Right, of course, sure. Modern software projects all consist of a handful of C files and a trivial makefile. No autotools or other makefile generators. No bugs in them, etc. -- Andriy Gapon