Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 9 Oct 2011 11:39:20 -0700
From:      Garrett Cooper <yanegomi@gmail.com>
To:        Chris Rees <crees@freebsd.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r226162 - head/share/mk
Message-ID:  <CAGH67wTrSucZ-UJPebYW54U4Ar4LS5D2A0tF074LNhQwtsxuew@mail.gmail.com>
In-Reply-To: <201110081825.p98IP22D073560@svn.freebsd.org>
References:  <201110081825.p98IP22D073560@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Oct 8, 2011 at 11:25 AM, Chris Rees <crees@freebsd.org> wrote:
> Author: crees (ports committer)
> Date: Sat Oct =A08 18:25:01 2011
> New Revision: 226162
> URL: http://svn.freebsd.org/changeset/base/226162
>
> Log:
> =A0Revert unapproved commit to bsd.port.mk.
>
> =A0This would have had more discussion, but it was explicitly rejected at=
 submission by portmgr:
>
> =A0http://lists.freebsd.org/pipermail/freebsd-ports/2011-September/070591=
.html

First off, I'm not advocating commit wars by reverting this change.
What I think happened was a simple misunderstanding, assumptions were
made, and an accidental lapse in communication occurred. It happens..
let's just try not to make the same mistake twice and move on.

I'm not currently blocked by this change if I upgrade to a later
version pending that I unmerge this change via svn merge -c -226162.
That being said, not everyone uses svn to manage /usr/src though
(cv?sup comes to mind), so I think it would be smart to revert this
change primarily for those individuals so they don't have to grow a
new custom system for applying patches, similar to what the FreeNAS
build system's build/do_build.sh script does, and so we can have
greater test coverage with 10-CURRENT in the coming months until all
of the ports breakage from the double digit branding scheme is fully
resolved.

Thanks!
-Garrett



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGH67wTrSucZ-UJPebYW54U4Ar4LS5D2A0tF074LNhQwtsxuew>