From owner-cvs-src@FreeBSD.ORG Thu Oct 25 19:57:20 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 22B0916A417; Thu, 25 Oct 2007 19:57:20 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (nagual.pp.ru [194.87.13.69]) by mx1.freebsd.org (Postfix) with ESMTP id 6C2DF13C4A7; Thu, 25 Oct 2007 19:57:18 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.14.1/8.14.1) with ESMTP id l9PJvA2C017528; Thu, 25 Oct 2007 23:57:10 +0400 (MSD) (envelope-from ache@nagual.pp.ru) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=nagual.pp.ru; s=default; t=1193342230; bh=3A03M6+SK8JQ609+JCHwYv3/Ss+jBce6OJw0ML9 C+Jo=; l=1384; h=Date:From:To:Cc:Subject:Message-ID: Mail-Followup-To:References:MIME-Version:Content-Type: Content-Disposition:In-Reply-To:User-Agent; b=o4NGFPjbMNv3wjPAlkYh AuhJVERJcdhpyvrUDfSQ5vQscd1DF3JaTXY/UNTnuQTUtoGxEAeWS9UmTtAY8dfKb9j 8I3JRbg6driNkdVBIoJB5daFxHiTPutnygqojfAWRdA/WGzLwdwK9+bhNegAUKD8Mv0 h61MBnBi3L8E0J3xE= Received: (from ache@localhost) by nagual.pp.ru (8.14.1/8.14.1/Submit) id l9PJvAkl017527; Thu, 25 Oct 2007 23:57:10 +0400 (MSD) (envelope-from ache) Date: Thu, 25 Oct 2007 23:57:09 +0400 From: Andrey Chernov To: Daniel Eischen Message-ID: <20071025195709.GA17384@nagual.pp.ru> Mail-Followup-To: Andrey Chernov , Daniel Eischen , d@delphij.net, Scott Long , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org References: <200710150951.l9F9pUm7026506@repoman.freebsd.org> <4720B30F.4040903@samsco.org> <20071025151707.GA11398@nagual.pp.ru> <4720C7D6.9090004@delphij.net> <20071025190019.GA16187@nagual.pp.ru> <4720E9E1.7000900@delphij.net> <20071025192501.GG16187@nagual.pp.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.16 (2007-06-09) Cc: cvs-src@FreeBSD.org, Scott Long , src-committers@FreeBSD.org, d@delphij.net, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libc/locale utf8.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Oct 2007 19:57:20 -0000 On Thu, Oct 25, 2007 at 03:31:20PM -0400, Daniel Eischen wrote: >> Although standard permit this, it will cause lots of programs to break >> here and there and even may cause core dump. I don't think it is what >> everybody wants. Non-inlined versions a) not used nowdays b) must be exact >> as inlined. > > If programs are incorrectly written, and they use inlines, then > that is not our fault :-) The amount of such programs is extremely big to ignore, even FreeBSD is not 100% clean, not say about ports. Usually ASCII-only people did't notice any side effects because typed 7-bit ASCII. It doesn't mean that the rest of the world don't exists. > The problem with trying to do error checking and other Error checking is permitted by standard too. We do that way traditionally. Nobody wants a core dump on typed char. Ad the PR addressed was about false positives, which would happens without error checking. > esoteric things with inlines is that it exposes our private > parts to the world. You can get arrested for that ;-) There is enough parts already exposed, like __mb_cur_max. Why you don't complain? The goal here was to keep compatibility with old binaries, so why this way is choosed. > How much juice are we really trying to squeeze out of > these inlines anyway? Not sure what you say about. -- http://ache.pp.ru/