From owner-svn-src-head@freebsd.org Sun Jun 4 18:06:31 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C2FC8B94627; Sun, 4 Jun 2017 18:06:31 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 86AF47E66A; Sun, 4 Jun 2017 18:06:31 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (unknown [127.0.1.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by freefall.freebsd.org (Postfix) with ESMTPS id A3A6A14240; Sun, 4 Jun 2017 18:06:30 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id C33617327; Sun, 4 Jun 2017 18:06:29 +0000 (UTC) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id 1rvKYs5FzXMC; Sun, 4 Jun 2017 18:06:23 +0000 (UTC) Subject: Re: svn commit: r319507 - head/sys/fs/msdosfs DKIM-Filter: OpenDKIM Filter v2.9.2 mail.xzibition.com C31027321 To: Bruce Evans , Ed Maste Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201706021839.v52IdrZJ074478@repo.freebsd.org> <20170603161546.D939@besplex.bde.org> From: Bryan Drewery Openpgp: id=F9173CB2C3AAEA7A5C8A1F0935D771BB6E4697CF; url=http://www.shatow.net/bryan/bryan2.asc Organization: FreeBSD Message-ID: <543a4144-4f08-8742-5455-0103569d9f4f@FreeBSD.org> Date: Sun, 4 Jun 2017 11:06:07 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <20170603161546.D939@besplex.bde.org> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="OCrjEcmq8O6hrQ68b5c71DDe4cvVqeKtq" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 04 Jun 2017 18:06:31 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --OCrjEcmq8O6hrQ68b5c71DDe4cvVqeKtq Content-Type: multipart/mixed; boundary="qUGl03JLwVNA2HpXXDCCneJWFr43Kmgp9"; protected-headers="v1" From: Bryan Drewery To: Bruce Evans , Ed Maste Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: <543a4144-4f08-8742-5455-0103569d9f4f@FreeBSD.org> Subject: Re: svn commit: r319507 - head/sys/fs/msdosfs References: <201706021839.v52IdrZJ074478@repo.freebsd.org> <20170603161546.D939@besplex.bde.org> In-Reply-To: <20170603161546.D939@besplex.bde.org> --qUGl03JLwVNA2HpXXDCCneJWFr43Kmgp9 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 6/3/2017 12:05 AM, Bruce Evans wrote: > bcopy() is essentially the same as memmove(), but is implemented more > optimally > (the non-use of memmove() in the kernel used to be implememented by > by not having it, but someone broke this by adding an memmove() wrapp= er > which is an extern function that calls bcopy(). This is even slower = than > the inline wrappers used to break intentionally leaving out some of t= he > other functions). In r189170. It seems to me we should change systm.h back to a macro #define memmove(dst, src, len) bcopy((src), (dst), (len)) And then keep the symbol in sys/libkern/memmove.c for the cases where Clang insists on having the symbol for linking. --=20 Regards, Bryan Drewery --qUGl03JLwVNA2HpXXDCCneJWFr43Kmgp9-- --OCrjEcmq8O6hrQ68b5c71DDe4cvVqeKtq Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJZNEwPAAoJEDXXcbtuRpfPCDMIAJJuFe9csw5t9YYMW9OfR5UB wA0+zd0E9B1NLt+kAcU5vfLUPvp6HOCUYbZHR6GTmJ0XHMswCaTRXwWDWqztf7Xj +M9W1ILIjnQHpL9wnfPtm8Vw7tt3WWNL1R8Z4wgpZnmCGrH2JRSLhyO63lmTOxHa viTqZAY0YpUC48nOT2C2JCeyG8h2l2a03zjBgTVJLFg9nngr9uxukegtuVWr5Qcr KH/riVda148KPsY8bJieXXurKKr5jK/yOOFZsvI/DO9NP0WVuY4h9/3Vx+MMbwv0 3VViZQRaOXYXri1dLybpX7DKIUQVcoaOG271RVsXIvy/p2gilXRPYgl9s+Rc4Ag= =T/nM -----END PGP SIGNATURE----- --OCrjEcmq8O6hrQ68b5c71DDe4cvVqeKtq--