From owner-freebsd-current@FreeBSD.ORG Mon Jan 23 03:38:15 2012 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C92F9106564A for ; Mon, 23 Jan 2012 03:38:15 +0000 (UTC) (envelope-from yuri.pankov@gmail.com) Received: from sirius.xvoid.org (sirius.xvoid.org [IPv6:2001:470:28:4ba:20c:29ff:fe62:9a22]) by mx1.freebsd.org (Postfix) with ESMTP id 6D8AD8FC12 for ; Mon, 23 Jan 2012 03:38:15 +0000 (UTC) Received: from sirius.xvoid.org (yuri@sirius.xvoid.org [IPv6:::1]) by sirius.xvoid.org (8.14.5/8.14.5) with ESMTP id q0N3cDbb095310; Mon, 23 Jan 2012 07:38:13 +0400 (MSK) (envelope-from yuri.pankov@gmail.com) Received: (from yuri@localhost) by sirius.xvoid.org (8.14.5/8.14.5/Submit) id q0N3cCjD095309; Mon, 23 Jan 2012 07:38:12 +0400 (MSK) (envelope-from yuri.pankov@gmail.com) X-Authentication-Warning: sirius.xvoid.org: yuri set sender to yuri.pankov@gmail.com using -f Date: Mon, 23 Jan 2012 07:38:12 +0400 From: Yuri Pankov To: Kostik Belousov Message-ID: <20120123033812.GC10149@sirius.xvoid.org> References: <20120123013642.GB10149@sirius.xvoid.org> <20120123030513.GK31224@deviant.kiev.zoral.com.ua> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120123030513.GK31224@deviant.kiev.zoral.com.ua> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: freebsd-current@freebsd.org Subject: Re: panic: No NCF_TS X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Jan 2012 03:38:15 -0000 On Mon, Jan 23, 2012 at 05:05:13AM +0200, Kostik Belousov wrote: > On Mon, Jan 23, 2012 at 05:36:42AM +0400, Yuri Pankov wrote: > > Seems to be reproducible here running r230467 as the NFS client and > > r230135 as NFS server. NFSv4 not enabled. > > > > # mount > > [...] > > sirius:/data/distfiles on /usr/ports/distfiles (nfs) > > > > # /usr/bin/env /usr/bin/fetch -AFpr -S 4682084 -o /usr/ports/distfiles/sqlite-src-3071000.zip http://www.sqlite.org/sqlite-src-3071000.zip > > /usr/ports/distfiles/sqlite-src-3071000.zip 100% of 4572 kB 379 kBps 00m00s > > # rm /usr/ports/distfiles/sqlite-src-3071000.zip > > > > immediately followed by: > > > > panic: No NCF_TS > > cpuid = 2 > > KDB: enter: panic > > [ thread pid 1603 tid 100494 ] > > Stopped at kdb_enter+0x3e: movq $0,kdb_why > > db> bt > > Tracing pid 1603 tid 100494 td 0xfffffe0089585460 > > kdb_enter() at kdb_enter+0x3e > > panic() at panic+0x245 > > cache_lookup_times() at cache_lookup_times+0x6b5 > > nfs_lookup() at nfs_lookup+0x190 > > VOP_LOOKUP_APV() at VOP_LOOKUP_APV+0x8b > > lookup() at lookup+0x7e9 > > namei() at namei+0x74c > > kern_statat_vnhook() at kern_statat_vnhook+0x90 > > sys_lstat() at sys_lstat+0x30 > > amd64_syscall() at amd64_syscall+0x221 > > Xfast_syscall() at Xfast_syscall+0xfb > > --- syscall (190, FreeBSD ELF64, sys_lstat), rip = 0x80093ff3c, rsp = 0x7fffffffd8d8, rbp = 0x7fffffffd979 --- > > > > Yes, my bad. I wrote the r230441 with the assumption that filesystems > are consistent in their use of cache_enter_time(). And my net-booting > test box did not catched this, which is at least interesting. > > Please try the change below. Actually, it should be enough to only apply > the changes for fs/nfsclient (or nfsclient/ if you use old nfs). If this > does not help, then please try the whole patch. > > Even if not needed for correctness, I think vfs_cache.c change could > be made useful by adding KASSERT to it. Thanks, applying only the fs/nfsclient part of the patch helped. No problems after applying the full patch as well. Yuri