40wQgv2Oa8/W8pa3j8OZRF94pih+H0VgYBmmKQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1770039084; a=rsa-sha256; cv=none; b=oZA3QDnDli12Ue/+/bhvpYzS0vyBCl16QHJVNk/MxiseCFYAJsUGO9/vhRqCe6+WRwv9PH wFdioFhPffVjt3W0douFlmiTuwtPtRoDOcjNG4tJvJkwIC3t//GrNf9UlTrC6eQZbJlb0G PAXsH2oTl9bjhGmjBBX+o2AIIBlyNOBKgxEki2nzjzB12bK3KlVLBBd/IL5Y2jQpm/KUhc 9iWuS8RIv12fairGImbI5wE6r1DKGz2Bob0Ht1fTXmKiWNTY7kp6uGG2MKmzkua6RQuBYE M8YlJTOWeVLLkDiMZPxNsFC+ee0E0z6LmbO9h7mjJF8bvm46DAE0xft9QTEnzQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770039084; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=xEe+sD4iqRFy8SJalSBILLxd6Ak86msOXxlYMfB+Ot0=; b=DaXfuB/h6L/wXEiVJEpc9L0i1zAwAyf8gcUycT9oufUkcJR5u008abqAqvRXZq4+09qkqO 6EcnOW59KqXRK9ZN1u/5f9vNocfb/VgK3pwUGsUevmQw+Y3bBAR3kUB1csZzWyuET6tp5q JfgULwK8bZSKsWZgNYFbfk6XxOeqXxa+l+NjP5VCRE1t3/Ogiqw1kysz33TN+00VozIDTT HMQSrZecnwO1w7Db7/zI5AYUD70Vpu2GplHxvqGlfKgDoXqigxPxWy9yDgrX0pR6LYHqqs wvqmayWvIepDK9lpaDtOR1Hi85cbxjEVsYADlBNrc6zdo8UYcpCF4lMRRiBNqg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4f4SF83FctzCbM for ; Mon, 02 Feb 2026 13:31:24 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 31385 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 02 Feb 2026 13:31:24 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Warner Losh Subject: git: ff9fe85ff245 - main - nvmecontrol: telemetry-log don't sanity check host generation number List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: ff9fe85ff245bfbf6f54f98175282be5cf500cb3 Auto-Submitted: auto-generated Date: Mon, 02 Feb 2026 13:31:24 +0000 Message-Id: <6980a72c.31385.4fe39fee@gitrepo.freebsd.org> The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=ff9fe85ff245bfbf6f54f98175282be5cf500cb3 commit ff9fe85ff245bfbf6f54f98175282be5cf500cb3 Author: Warner Losh AuthorDate: 2026-02-02 13:30:22 +0000 Commit: Warner Losh CommitDate: 2026-02-02 13:31:21 +0000 nvmecontrol: telemetry-log don't sanity check host generation number Don't sanity check the host initiated generation number. It's not necessarily constant between the two log page fetches. nvme-cli doesn't do this stanity check and it generates a lot of false positives. Sponsored by: Netflix Differential Revision: https://reviews.freebsd.org/D55018 --- sbin/nvmecontrol/telemetry.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/sbin/nvmecontrol/telemetry.c b/sbin/nvmecontrol/telemetry.c index bfa1325974d5..c22d53ecdfed 100644 --- a/sbin/nvmecontrol/telemetry.c +++ b/sbin/nvmecontrol/telemetry.c @@ -160,16 +160,6 @@ telemetry_log(const struct cmd *f, int argc, char *argv[]) chunk = size; read_logpage(fd, NVME_LOG_TELEMETRY_HOST_INITIATED, nsid, 0, 0, true, off, 0, 0, 0, &buf, chunk); - if (off == 0) { - /* - * Sanity check to make sure that the generation number - * didn't change between the two reads. - */ - if (tlp.hi_gen != buf.hi_gen) - warnx( - "Generation number changed from %d to %d", - tlp.hi_gen, buf.hi_gen); - } if (write(fdout, &buf, chunk) != chunk) err(EX_IOERR, "Error writing %s", opt.outfn); off += chunk;