From owner-dev-commits-src-main@freebsd.org  Tue Apr 13 15:23:52 2021
Return-Path: <owner-dev-commits-src-main@freebsd.org>
Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id A90CD5E3C67;
 Tue, 13 Apr 2021 15:23:52 +0000 (UTC) (envelope-from jhb@FreeBSD.org)
Received: from smtp.freebsd.org (smtp.freebsd.org
 [IPv6:2610:1c1:1:606c::24b:4])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 4FKTsN4VdNz4pG9;
 Tue, 13 Apr 2021 15:23:52 +0000 (UTC) (envelope-from jhb@FreeBSD.org)
Received: from John-Baldwins-MacBook-Pro.local (ralph.baldwin.cx
 [66.234.199.215])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client did not present a certificate) (Authenticated sender: jhb)
 by smtp.freebsd.org (Postfix) with ESMTPSA id 2414A2CD35;
 Tue, 13 Apr 2021 15:23:52 +0000 (UTC) (envelope-from jhb@FreeBSD.org)
Subject: Re: git: 73c14cc76b5f - main - Remove history.immutable from
 .arcconfig
To: Alex Richardson <arichardson@FreeBSD.org>, src-committers@FreeBSD.org,
 dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
References: <202104131138.13DBcgrt085662@gitrepo.freebsd.org>
From: John Baldwin <jhb@FreeBSD.org>
Message-ID: <9e0d4574-bcad-b24c-78ad-c172d6d2c221@FreeBSD.org>
Date: Tue, 13 Apr 2021 08:23:50 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:78.0)
 Gecko/20100101 Thunderbird/78.9.0
MIME-Version: 1.0
In-Reply-To: <202104131138.13DBcgrt085662@gitrepo.freebsd.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-BeenThere: dev-commits-src-main@freebsd.org
X-Mailman-Version: 2.1.34
Precedence: list
List-Id: Commit messages for the main branch of the src repository
 <dev-commits-src-main.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/dev-commits-src-main>, 
 <mailto:dev-commits-src-main-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/dev-commits-src-main/>
List-Post: <mailto:dev-commits-src-main@freebsd.org>
List-Help: <mailto:dev-commits-src-main-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/dev-commits-src-main>, 
 <mailto:dev-commits-src-main-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 13 Apr 2021 15:23:52 -0000

On 4/13/21 4:38 AM, Alex Richardson wrote:
> The branch main has been updated by arichardson:
> 
> URL: https://cgit.FreeBSD.org/src/commit/?id=73c14cc76b5f815c6b1bd93089ebafdd9269d343
> 
> commit 73c14cc76b5f815c6b1bd93089ebafdd9269d343
> Author:     Alex Richardson <arichardson@FreeBSD.org>
> AuthorDate: 2021-04-13 11:36:24 +0000
> Commit:     Alex Richardson <arichardson@FreeBSD.org>
> CommitDate: 2021-04-13 11:36:25 +0000
> 
>      Remove history.immutable from .arcconfig
>      
>      The `history.immutable` setting prevents arcanist from updating
>      the commit messages with the Differential URL and therefore
>      makes updating patches awkward with a rebase workflow.
>      
>      In case this new behaviour is not wanted the old one can be restored
>      by running `arc set-config --local history.immutable true`.
>      
>      Test Plan: `arc diff --create HEAD^` adds the metadata now.
>      
>      Reviewed By:    #phabric-admin, imp, lwhsu
>      Differential Revision: https://reviews.freebsd.org/D27971

FYI, this might break git arc since arc will now start rewriting commits
rather than leaving them alone.  If so, we can look use 'arc diff'
with --head to turn off some of its magic.  It would also avoid having
'git arc' have to adjust the working copy.

-- 
John Baldwin