From owner-cvs-src@FreeBSD.ORG  Wed Jun  9 22:53:44 2004
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 90A9016A4CE; Wed,  9 Jun 2004 22:53:44 +0000 (GMT)
Received: from fledge.watson.org (fledge.watson.org [204.156.12.50])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 32CBD43D48; Wed,  9 Jun 2004 22:53:44 +0000 (GMT)
	(envelope-from hmp@freebsd.org)
Received: from fledge.watson.org (localhost [127.0.0.1])
	by fledge.watson.org (8.12.11/8.12.11) with ESMTP id i59Mqffv017955;
	Wed, 9 Jun 2004 18:52:41 -0400 (EDT)
	(envelope-from hmp@freebsd.org)
Received: from localhost (hmp@localhost)i59Mqf10017952;
	Wed, 9 Jun 2004 18:52:41 -0400 (EDT)	(envelope-from hmp@freebsd.org)
X-Authentication-Warning: fledge.watson.org: hmp owned process doing -bs
Date: Wed, 9 Jun 2004 18:52:41 -0400 (EDT)
From: Hiten Pandya <hmp@freebsd.org>
X-X-Sender: hmp@fledge.watson.org
To: Andre Oppermann <andre@freebsd.org>
In-Reply-To: <40C78104.F12A8948@freebsd.org>
Message-ID: <20040609184556.N14244@fledge.watson.org>
References: <200406091924.i59JOM9g016284@repoman.freebsd.org>
 <40C78104.F12A8948@freebsd.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: cvs-src@freebsd.org
cc: src-committers@freebsd.org
cc: cvs-all@freebsd.org
Subject: Re: cvs commit: src/lib/libc/stdio fclose.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 09 Jun 2004 22:53:44 -0000

On Wed, 9 Jun 2004, Andre Oppermann wrote:

 :Hiten Pandya wrote:
 :>
 :> hmp         2004-06-09 19:24:22 UTC
 :>
 :>   FreeBSD src repository
 :>
 :>   Modified files:        (Branch: RELENG_4)
 :>     lib/libc/stdio       fclose.c
 :>   Log:
 :>   Revert previous commit regarding FUNLOCKFILE(fp), it has ill effects.
 :
 :What ill effects does it have?  I've "make world" a couple of server
 :with this in.  Do I have to remake them again or is it unlikely that
 :I run across the probems?

	Well, the ill effects that I came across was that people
	reported Mozilla and net/freeradius hanging with this change

	As to why it was happening; that's because of inappropriate
	logic employed in lib/libc_r/uthread/uthread_file.c, i.e.,
	in the implementation of the funlockfile() function; it
	checks wether FILE->_file >= 0.  By moving the call to
	FUNLOCKFILE below modification of file flags, it got
	confused because fclose(3) was setting FILE->_file to -1,
	thus leading to a confused FUNLOCKFILE.

	With regard to the problems, you can just recompile your
	libc and it should go away.

	Regards,

	Hiten Pandya
	hmp at freebsd.org