From owner-freebsd-bugs Wed Jun 20 20:35:10 2001 Delivered-To: freebsd-bugs@freebsd.org Received: from mailsrv.otenet.gr (mailsrv.otenet.gr [195.170.0.5]) by hub.freebsd.org (Postfix) with ESMTP id C886237B406 for ; Wed, 20 Jun 2001 20:35:02 -0700 (PDT) (envelope-from keramida@ceid.upatras.gr) Received: from hades.hell.gr (patr530-a187.otenet.gr [212.205.215.187]) by mailsrv.otenet.gr (8.11.1/8.11.1) with ESMTP id f5L3YsS02221; Thu, 21 Jun 2001 06:34:56 +0300 (EEST) Received: (from charon@localhost) by hades.hell.gr (8.11.4/8.11.3) id f5L3Ylb09156; Thu, 21 Jun 2001 06:34:47 +0300 (EEST) (envelope-from keramida@ceid.upatras.gr) Date: Thu, 21 Jun 2001 06:34:45 +0300 From: Giorgos Keramidas To: Dima Dorfman Cc: freebsd-bugs@freebsd.org Subject: Re: kern/28297: change request for sys/i386/conf/NOTES Message-ID: <20010621063443.A9089@hades.hell.gr> References: <200106202220.f5KMK3x74622@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <200106202220.f5KMK3x74622@freefall.freebsd.org>; from dima@unixfreak.org on Wed, Jun 20, 2001 at 03:20:03PM -0700 X-PGP-Fingerprint: 3A 75 52 EB F1 58 56 0D - C5 B8 21 B6 1B 5E 4A C2 X-URL: http://students.ceid.upatras.gr/~keramida/index.html Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org On Wed, Jun 20, 2001 at 03:20:03PM -0700, Dima Dorfman wrote: > > Giorgos Keramidas writes: > > > > >Number: 28297 > > >Category: kern > > >Synopsis: change request for sys/i386/conf/NOTES > > >Description: > > > > The NOTES file of 5.0-CURRENT (CVSup'ed yesterday, Tue Jun 19 2001), > > says the following in the description of NTIMECOUNTER > > > > # The default is 5, there is no upper limit but more than a couple > > # of hundred are not productive. > > > > But the value of NTIMECOUNTER in NOTES a few lines below is 20. > > > > options NTIMECOUNTER=20 > > > > >Fix: > > > > Change either the description to match the default, > > or the default to match the description. > > NOTES isn't supposed to set the variables to their defaults. NOTES is > supposed to set variables to values *other* than the default to > potentially catch places where the default is hardcoded in (which > shouldn't be). Yes, if NOTES is not supposed to set variables to their defaults, this seems reasonable. Am sure we can close this PR in that case. The comment seemed to indicate that this is the default though. Perhaps we should reword the comment to read something like: The default is 5, although you can set it to any other value (for instance 20) as shown below. -giorgos To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message