Date: Tue, 22 May 2012 07:44:34 -0700 From: Garrett Cooper <yanegomi@gmail.com> To: Dimitry Andric <dim@freebsd.org> Cc: svn-src-head@freebsd.org, =?ISO-8859-1?Q?Dag=2DErling_Sm=F8rgrav?= <des@des.no>, Baptiste Daroussin <bapt@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org Subject: Re: svn commit: r235723 - in head: contrib/byacc tools/regression/usr.bin/yacc usr.bin/yacc usr.bin/yacc/test Message-ID: <CAGH67wTW8mL4=px8ks__rMhJGrivONkHGKXw72Wqk0Txvw%2B6yA@mail.gmail.com> In-Reply-To: <4FBB9551.6060407@FreeBSD.org> References: <201205211331.q4LDVRvB060077@svn.freebsd.org> <86likkpla9.fsf@ds4.des.no> <4FBB9551.6060407@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, May 22, 2012 at 6:32 AM, Dimitry Andric <dim@freebsd.org> wrote:
> On 2012-05-22 12:22, Dag-Erling Sm=F8rgrav wrote:
>> Baptiste Daroussin <bapt@FreeBSD.org> writes:
>>> Log:
>>> =A0 Import byacc from invisible island, it brings us lots of compatibil=
ities with
>>> =A0 bison, keeping full compatibility with our previous yacc
>>> =A0 implementation.
>>
>> This commit broke the build, in large part because Baptiste tested with
>> Clang instead of GCC, and GCC generates a warning when compiling the
>> generated code.
>
> It doesn't seem to compile with clang either, at least not as of r235777:
>
> /usr/src/bin/expr/expr.y:291:2: error: implicit declaration of function '=
yyparse' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
> =A0 =A0 =A0 =A0yyparse();
> =A0 =A0 =A0 =A0^
>
> Note that it looks like the expr.c file is still generated with the
> system yacc, so I'm not entirely sure what's going on here...
I mentioned it in a private email, but the issue is that the yacc
used during the build seems to be coming from the base system (despite
the fact that it's a bootstrap tool). Once I installed yacc onto my
stable-9 system at work, all of the changes that should have been
checked in with this commit became apparent.
Thanks,
-Garrett
1022 .if ${BOOTSTRAPPING} < 900006
1023 _lex=3D usr.bin/lex
1024 _yacc=3D usr.bin/yacc
1025 .endif
# ...
1068 bootstrap-tools:
1069 .for _tool in \
1070 ${_clang_tblgen} \
1071 ${_kerberos5_bootstrap_tools} \
1072 ${_dtrace_tools} \
1073 ${_strfile} \
1074 ${_gperf} \
1075 ${_groff} \
1076 ${_ar} \
1077 ${_dtc} \
1078 ${_awk} \
1079 usr.bin/lorder \
1080 usr.bin/makewhatis \
1081 ${_mklocale} \
1082 usr.bin/rpcgen \
1083 ${_sed} \
1084 ${_lex} \
1085 ${_yacc} \
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGH67wTW8mL4=px8ks__rMhJGrivONkHGKXw72Wqk0Txvw%2B6yA>