From owner-svn-src-head@FreeBSD.ORG Tue May 22 14:44:36 2012 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 00B32106566C; Tue, 22 May 2012 14:44:36 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-qc0-f182.google.com (mail-qc0-f182.google.com [209.85.216.182]) by mx1.freebsd.org (Postfix) with ESMTP id 50D798FC17; Tue, 22 May 2012 14:44:35 +0000 (UTC) Received: by qcsg15 with SMTP id g15so5076425qcs.13 for ; Tue, 22 May 2012 07:44:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=zRejOaO8OESRFMS7+XA8jlCiiMDx7qyYYk33c78BgdI=; b=b/yCzNoU9nRrgDtPDt7v1fgOPOz0Fig8xji0+RFyPaNznf8J13hGpV76bxB6CfHrjC BXjoNAzA3pxXc7ImLfBz3912lKQ3mlgPriS9F3NiveFCERFuzq4Z5uF5Vrrom0ZfSA4B olZTipM52S0MGMJp4veWnwqh1KexFMY6A4spGNjfzqSO+kpfE/Lnr31UGzQoFnoF8IcZ vfbo282ZGUBVI1OIuFjZN9rEX6gblNqdKhI1/bu7f6M9w1GZJKPBecyE+i+hXd03vGX3 3mAWcfmksMeGSxaH2tRcWfhT6F1FdDbC7isAbopUeIEnm9GDcGkUYnYjO6uo/fpsJvAd cr3w== MIME-Version: 1.0 Received: by 10.60.20.70 with SMTP id l6mr22911858oee.38.1337697874433; Tue, 22 May 2012 07:44:34 -0700 (PDT) Received: by 10.76.153.72 with HTTP; Tue, 22 May 2012 07:44:34 -0700 (PDT) In-Reply-To: <4FBB9551.6060407@FreeBSD.org> References: <201205211331.q4LDVRvB060077@svn.freebsd.org> <86likkpla9.fsf@ds4.des.no> <4FBB9551.6060407@FreeBSD.org> Date: Tue, 22 May 2012 07:44:34 -0700 Message-ID: From: Garrett Cooper To: Dimitry Andric Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: svn-src-head@freebsd.org, =?ISO-8859-1?Q?Dag=2DErling_Sm=F8rgrav?= , Baptiste Daroussin , src-committers@freebsd.org, svn-src-all@freebsd.org Subject: Re: svn commit: r235723 - in head: contrib/byacc tools/regression/usr.bin/yacc usr.bin/yacc usr.bin/yacc/test X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 May 2012 14:44:36 -0000 On Tue, May 22, 2012 at 6:32 AM, Dimitry Andric wrote: > On 2012-05-22 12:22, Dag-Erling Sm=F8rgrav wrote: >> Baptiste Daroussin writes: >>> Log: >>> =A0 Import byacc from invisible island, it brings us lots of compatibil= ities with >>> =A0 bison, keeping full compatibility with our previous yacc >>> =A0 implementation. >> >> This commit broke the build, in large part because Baptiste tested with >> Clang instead of GCC, and GCC generates a warning when compiling the >> generated code. > > It doesn't seem to compile with clang either, at least not as of r235777: > > /usr/src/bin/expr/expr.y:291:2: error: implicit declaration of function '= yyparse' is invalid in C99 [-Werror,-Wimplicit-function-declaration] > =A0 =A0 =A0 =A0yyparse(); > =A0 =A0 =A0 =A0^ > > Note that it looks like the expr.c file is still generated with the > system yacc, so I'm not entirely sure what's going on here... I mentioned it in a private email, but the issue is that the yacc used during the build seems to be coming from the base system (despite the fact that it's a bootstrap tool). Once I installed yacc onto my stable-9 system at work, all of the changes that should have been checked in with this commit became apparent. Thanks, -Garrett 1022 .if ${BOOTSTRAPPING} < 900006 1023 _lex=3D usr.bin/lex 1024 _yacc=3D usr.bin/yacc 1025 .endif # ... 1068 bootstrap-tools: 1069 .for _tool in \ 1070 ${_clang_tblgen} \ 1071 ${_kerberos5_bootstrap_tools} \ 1072 ${_dtrace_tools} \ 1073 ${_strfile} \ 1074 ${_gperf} \ 1075 ${_groff} \ 1076 ${_ar} \ 1077 ${_dtc} \ 1078 ${_awk} \ 1079 usr.bin/lorder \ 1080 usr.bin/makewhatis \ 1081 ${_mklocale} \ 1082 usr.bin/rpcgen \ 1083 ${_sed} \ 1084 ${_lex} \ 1085 ${_yacc} \