From owner-freebsd-usb@FreeBSD.ORG Fri Jan 13 17:10:08 2012 Return-Path: Delivered-To: freebsd-usb@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D3F571065673 for ; Fri, 13 Jan 2012 17:10:08 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 93E7F8FC13 for ; Fri, 13 Jan 2012 17:10:08 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q0DHA8Hw002140 for ; Fri, 13 Jan 2012 17:10:08 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q0DHA8cc002139; Fri, 13 Jan 2012 17:10:08 GMT (envelope-from gnats) Resent-Date: Fri, 13 Jan 2012 17:10:08 GMT Resent-Message-Id: <201201131710.q0DHA8cc002139@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-usb@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Mykhaylo Yehorov Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C59A11065678 for ; Fri, 13 Jan 2012 17:05:29 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id B245C8FC17 for ; Fri, 13 Jan 2012 17:05:29 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.4/8.14.4) with ESMTP id q0DH5TaD030021 for ; Fri, 13 Jan 2012 17:05:29 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.4/8.14.4/Submit) id q0DH5Tko030020; Fri, 13 Jan 2012 17:05:29 GMT (envelope-from nobody) Message-Id: <201201131705.q0DH5Tko030020@red.freebsd.org> Date: Fri, 13 Jan 2012 17:05:29 GMT From: Mykhaylo Yehorov To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: usb/164090: [umodem] [patch] Add sysctl with ucom unit number X-BeenThere: freebsd-usb@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: FreeBSD support for USB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Jan 2012 17:10:08 -0000 >Number: 164090 >Category: usb >Synopsis: [umodem] [patch] Add sysctl with ucom unit number >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-usb >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Fri Jan 13 17:10:08 UTC 2012 >Closed-Date: >Last-Modified: >Originator: Mykhaylo Yehorov >Release: FreeBSD 9.0-RELEASE >Organization: >Environment: FreeBSD atom.lan29.local 9.0-RELEASE FreeBSD 9.0-RELEASE #7: Fri Jan 13 15:18:21 EET 2012 mika@atom.lan29.local:/usr/obj/usr/src/sys/MINI_KVA384 i386 >Description: Now there is no easy way to determine which tty device file is used by an umodem device. With the following patch the umodem driver will create sysctl node dev.umodem.X.ucom. This sysctl will be helpful in devd scripts. >How-To-Repeat: >Fix: Patch attached with submission follows: --- orig/sys/dev/usb/serial/umodem.c 2011-11-11 06:20:22.000000000 +0200 +++ sys/dev/usb/serial/umodem.c 2012-01-03 13:06:14.371630639 +0200 @@ -169,6 +169,8 @@ uint8_t sc_cm_over_data; uint8_t sc_cm_cap; /* CM capabilities */ uint8_t sc_acm_cap; /* ACM capabilities */ + + int ucom_unit; }; static device_probe_t umodem_probe; @@ -412,6 +414,13 @@ } ucom_set_pnpinfo_usb(&sc->sc_super_ucom, dev); + sc->ucom_unit = sc->sc_super_ucom.sc_unit; + + SYSCTL_ADD_INT(device_get_sysctl_ctx(dev), + SYSCTL_CHILDREN(device_get_sysctl_tree(dev)), + OID_AUTO, "ucom", CTLFLAG_RD, + &sc->ucom_unit, -1, "Attached ucom unit number"); + return (0); detach: >Release-Note: >Audit-Trail: >Unformatted: