From owner-freebsd-hackers@freebsd.org  Mon Mar 26 21:46:18 2018
Return-Path: <owner-freebsd-hackers@freebsd.org>
Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 49DD6F6E3F2
 for <freebsd-hackers@mailman.ysv.freebsd.org>;
 Mon, 26 Mar 2018 21:46:18 +0000 (UTC) (envelope-from stb@lassitu.de)
Received: from gilb.zs64.net (gilb.zs64.net [IPv6:2a00:14b0:4200:32e0::1ea])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "gilb.zs64.net", Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id E036F75C38
 for <freebsd-hackers@FreeBSD.org>; Mon, 26 Mar 2018 21:46:17 +0000 (UTC)
 (envelope-from stb@lassitu.de)
Received: by gilb.zs64.net (Postfix, from stb@lassitu.de) id ACB82247F
 for <freebsd-hackers@FreeBSD.org>; Mon, 26 Mar 2018 21:46:15 +0000 (UTC)
From: Stefan Bethke <stb@lassitu.de>
Content-Type: text/plain;
	charset=utf-8
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0 (Mac OS X Mail 11.2 \(3445.5.20\))
Subject: Bugzilla converts patch to CRLF line endings?
Message-Id: <AC4C81D8-A928-4E8C-A067-EE83EBF044F1@lassitu.de>
Date: Mon, 26 Mar 2018 23:46:14 +0200
To: freebsd-hackers@FreeBSD.org
X-Mailer: Apple Mail (2.3445.5.20)
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
 <freebsd-hackers.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-hackers>, 
 <mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers/>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
 <mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 26 Mar 2018 21:46:18 -0000

Hey,

I=E2=80=99ve submitted patched for the ports I maintain by copy/pasting =
the svn diff output into the Bugzilla attachment form for a long time.  =
The committer working on =
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D226941 noticed that =
the patch apparently has CRLF line endings, making it hard(er) to apply =
it properly.

Working on a Mac with Terminal and Safari, I have not have noticed any =
such behaviour. When I copy/paste from Bugzilla into Terminal, =
everything works just fine, so I can do =E2=80=9Ecd /usr/ports/cat/port; =
patch -p0=E2=80=9C then paste and ^D.

When I download the attachment from the =E2=80=9Eraw=E2=80=9C attachment =
link (in my example =
https://bz-attachments.freebsd.org/attachment.cgi?id=3D191852) with curl =
or wget, I do get to see CR-LF.

Where does that happen? And is that a bug or a feature?


Stefan

--=20
Stefan Bethke <stb@lassitu.de>   Fon +49 151 14070811