From owner-cvs-all@FreeBSD.ORG Tue Oct 5 23:11:18 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A51D316A4CF; Tue, 5 Oct 2004 23:11:18 +0000 (GMT) Received: from www.cryptography.com (li-22.members.linode.com [64.5.53.22]) by mx1.FreeBSD.org (Postfix) with ESMTP id 63F2543D45; Tue, 5 Oct 2004 23:11:18 +0000 (GMT) (envelope-from nate@root.org) Received: from [10.0.0.34] (adsl-67-119-74-222.dsl.sntc01.pacbell.net [67.119.74.222]) by www.cryptography.com (8.12.8/8.12.8) with ESMTP id i95NAfUQ029645 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Tue, 5 Oct 2004 16:10:42 -0700 Message-ID: <416329F0.3060301@root.org> Date: Tue, 05 Oct 2004 16:10:40 -0700 From: Nate Lawson User-Agent: Mozilla Thunderbird 0.7.3 (Windows/20040803) X-Accept-Language: en-us, en MIME-Version: 1.0 To: "Moore, Robert" References: <37F890616C995246BE76B3E6B2DBE0550237CFB3@orsmsx403.amr.corp.intel.com> In-Reply-To: <37F890616C995246BE76B3E6B2DBE0550237CFB3@orsmsx403.amr.corp.intel.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit cc: Takanori Watanabe cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org cc: John Baldwin cc: cvs-src@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/acpi/acpidump acpi.c acpidump.c acpidump.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Oct 2004 23:11:18 -0000 This request is for the SSDT. Our requirements are: 1. Leave default table 2. Override with a new one 3. Ignore the table (pretend it doesn't exist) The last one isn't possible with the current API. I've hacked up similar functionality by returning a no-op SSDT in AcpiOsTableOverride(). But this isn't an ideal solution. Thanks, Nate Moore, Robert wrote: > I can add this next time I open up this interface. > > I think there are a couple of other requests outstanding on > AcpiOsTableOverride(), perhaps in the SSDT area, I forget. > >>-----Original Message----- >>From: Nate Lawson [mailto:nate@root.org] >>Sent: Tuesday, October 05, 2004 2:31 PM >>To: John Baldwin >>Cc: Takanori Watanabe; src-committers@FreeBSD.org; > > cvs-src@FreeBSD.org; > >>cvs-all@FreeBSD.org >>Subject: Re: cvs commit: src/usr.sbin/acpi/acpidump acpi.c acpidump.c >>acpidump.h >> >>Nate Lawson wrote: >> >>>John Baldwin wrote: >>> >>>>I agree. It makes the user's lives a lot easier if they procedure >>>>remains: >>>> >>>>- acpidump > foo.asl >>>>- hack on foo.asl to fix it >>>>- compile foo.asl to foo.dsdt >>>>- load foo.dsdt in the loader >>>> >>>>and have it all just work. Actually, you know, we could make this >>>>work on our own without requiring ACPI-CA to change. You just need > > to > >>>>hack AcpiOsTableOverride() in OsdTable.c to return a pointer to an >>>>empty table for "SSDT" tables when the DSDT is overridden. In > > fact, I > >>>>think that is probably where this behavior decision really belongs. >>> >>>Good idea, I'll look into this. If feasible, I'll commit this and >>>revert the acpidump change. >> >>Ok, I've committed a tested version with this approach. The only >>annoying part is that setting NewTable to NULL means "don't override >>this one" so I had to supply an empty no-op table in place of the > > SSDT. > >> I backed out the acpidump changes. It would be better if ACPI-CA > > had > >>an option where returning AE_NO_TABLES or something would mean "ignore >>this table completely". Right now, you can only override or leave the >>default table. >> >>-- >>Nate > > -- Nate