From owner-freebsd-current@FreeBSD.ORG  Wed Sep 17 08:34:18 2008
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 273D31065670
	for <current@freebsd.org>; Wed, 17 Sep 2008 08:34:18 +0000 (UTC)
	(envelope-from ianf@clue.co.za)
Received: from munchkin.clue.co.za (munchkin.clue.co.za [66.219.59.160])
	by mx1.freebsd.org (Postfix) with ESMTP id E6E7D8FC33
	for <current@freebsd.org>; Wed, 17 Sep 2008 08:34:17 +0000 (UTC)
	(envelope-from ianf@clue.co.za)
DomainKey-Signature: a=rsa-sha1; q=dns; c=simple; s=20070313; d=clue.co.za;
	h=Received:Received:Received:To:Subject:From:X-Attribution:Date:Message-Id;
	b=ImEjhHiZ5GOX1/K7rVWqdiBkLcdrR9xaPStGcx0Wtoe4WXTOR3ALPaxcZcPsEZ9Hfwmhdbm8tjA/7d5RLKdXi/1VGymmE+STfcKJ1rGE0Z2T6EewIrCvOzS1+JxM384DvHL6N7Sh6mhrWBr2W4I00rS41mGhyljtJNEPnNIHQ14lOOH1WBqfTmRPUVj9+AxJjk6G8ltlUdBsaj5rulsKo5FuNqOuTJR/CgvhIyh8RQTsjVxyBkuIVpD19bB3/Ysn;
Received: from uucp by munchkin.clue.co.za with local-rmail (Exim 4.67)
	(envelope-from <ianf@clue.co.za>) id 1Kfs46-000478-Ie
	for current@freebsd.org; Wed, 17 Sep 2008 08:07:10 +0000
Received: from dsl-241-65-41.telkomadsl.co.za ([41.241.65.41] helo=clue.co.za)
	by urchin.clue.co.za with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.69)
	(envelope-from <ianf@clue.co.za>) id 1Kfs3p-0000f3-Us
	for current@freebsd.org; Wed, 17 Sep 2008 08:06:54 +0000
Received: from localhost ([127.0.0.1] helo=clue.co.za)
	by clue.co.za with esmtp (Exim 4.69 (FreeBSD))
	(envelope-from <ianf@clue.co.za>) id 1Kfs3n-0001CB-EC
	for current@freebsd.org; Wed, 17 Sep 2008 10:06:51 +0200
To: current@freebsd.org
From: "Ian Freislich" <ianf@clue.co.za>
X-Attribution: BOFH
Date: Wed, 17 Sep 2008 10:06:51 +0200
Message-Id: <E1Kfs3n-0001CB-EC@clue.co.za>
Cc: 
Subject: PATCH: crypto/openssl/crypto/engine/eng_table.c
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 17 Sep 2008 08:34:18 -0000

Hi

I had to apply the following patch to fix the engine cache in openssl
so that it will actually use the padlock driver for accelleration.
It appears that the original logic was reversed.

RCS file: /home/ncvs/src/crypto/openssl/crypto/engine/eng_table.c,v
retrieving revision 1.1.1.2
diff -u -d -r1.1.1.2 eng_table.c
--- eng_table.c 29 Jul 2006 19:10:18 -0000      1.1.1.2
+++ eng_table.c 12 Jun 2008 07:52:52 -0000
@@ -135,7 +135,7 @@
                        {
                        fnd = OPENSSL_malloc(sizeof(ENGINE_PILE));
                        if(!fnd) goto end;
-                       fnd->uptodate = 0;
+                       fnd->uptodate = 1;
                        fnd->nid = *nids;
                        fnd->sk = sk_ENGINE_new_null();
                        if(!fnd->sk)
@@ -152,7 +152,7 @@
                if(!sk_ENGINE_push(fnd->sk, e))
                        goto end;
                /* "touch" this ENGINE_PILE */
-               fnd->uptodate = 1;
+               fnd->uptodate = 0;
                if(setdefault)
                        {
                        if(!engine_unlocked_init(e))
@@ -180,7 +180,7 @@
                {
                sk_ENGINE_delete(pile->sk, n);
                /* "touch" this ENGINE_CIPHER */
-               pile->uptodate = 1;
+               pile->uptodate = 0;
                }
        if(pile->funct == e)
                {


--
Ian Freislich