From nobody Fri Jun 21 13:42:24 2024 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4W5JSk5bVpz5Nj3L for ; Fri, 21 Jun 2024 13:42:30 +0000 (UTC) (envelope-from daniel.engberg.lists@pyret.net) Received: from smtp-42ae.mail.infomaniak.ch (smtp-42ae.mail.infomaniak.ch [IPv6:2001:1600:4:17::42ae]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "relay.mail.infomaniak.ch", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4W5JSk2fR4z4mch for ; Fri, 21 Jun 2024 13:42:30 +0000 (UTC) (envelope-from daniel.engberg.lists@pyret.net) Authentication-Results: mx1.freebsd.org; none Received: from smtp-4-0000.mail.infomaniak.ch (smtp-4-0000.mail.infomaniak.ch [10.7.10.107]) by smtp-3-3000.mail.infomaniak.ch (Postfix) with ESMTPS id 4W5JSc3n6HzRhR; Fri, 21 Jun 2024 15:42:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pyret.net; s=20231006; t=1718977344; bh=GK0qji93+rSeuvaixobA4XObQ9NlPxbWUMeFJLdUXrA=; h=Date:Subject:From:Reply-To:To:Cc:References:In-Reply-To:From; b=AFXH4/IukA9VEnvzdXxMDnGmNFSgWRODrqCbn2j+jpDk1WTtBPx5SUL/F+zOlpqRc TINp1Hk7zE2yNJrXn6QeniBn6pOwDgZ/UPkvNLr49JXWH5gvEj659s1U3r2bcTiDd3 SPcS3sfopT+IbEnQ3K7mNH5kSiT1QYYVJ0INNra3Ed4zkukSyVm3jg7UUnyYecLG89 2sBoAgL8koj/eQ16ANljZklQoSDn6p+pRh1nXSjJmYTvEWntZto4KInbSwtwW0uhdD vNNx8Z3HBhTsYNxMnEMbYBE5vUHraGc8xsf6Hpvc/gmYn9/vlQNtF5QM6Wjxjy535x JV1eCLMheCv6g== Received: from unknown by smtp-4-0000.mail.infomaniak.ch (Postfix) with ESMTPA id 4W5JSc0wRHzDB9; Fri, 21 Jun 2024 15:42:24 +0200 (CEST) Message-ID: <224470ebe4c1f9da0c394a33cfde261e@mail.infomaniak.com> Date: Fri, 21 Jun 2024 15:42:24 +0200 Subject: Re: git: 12594e1aee7b - main - math/mathex: new port, C++ library to parse/evaluate mathematical expressions From: Daniel Engberg Reply-To: Daniel Engberg To: Thierry Thomas Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-main@freebsd.org Sender: owner-dev-commits-ports-main@FreeBSD.org MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="_=_swift_1718977344_af46be7226463506fb82fd1b251121a8_=_" X-WS-User-Origin: eyJpdiI6InE4VFAyWWJjTUIxSE5VN05uWDh1a3c9PSIsInZhbHVlIjoibUlxSWJGWjZIaEdLVVpLaTNoWlA0QT09IiwibWFjIjoiY2ViYzQyMTQyNmIwNmZhNGNiZDQyYmNkNDZhMzE4Y2JlMWVlNjgzMDFiZDQzOTU2NTg5MDhjMjM1NTUwODgyNiIsInRhZyI6IiJ9 X-WS-User-Mbox: eyJpdiI6ImNLaHh3VjkvNWwxUkJrRXF6OThuT0E9PSIsInZhbHVlIjoiQktERUVmN1M1Q05OWVkweU4yVXFCZz09IiwibWFjIjoiODI1YWJjNjQ1MzcyY2E5ZjAyYTEzYTlhNGUxY2QyNWY5ZGNiZWJlNGJkMmNjMTQ2NGJmMjUzNmE0NmJkMTUwNSIsInRhZyI6IiJ9 X-WS-Location: eJxzKUpMKykGAAfpAmU- X-Mailer: Infomaniak Workspace (1.3.703) References: <202406211115.45LBFt3m025401@gitrepo.freebsd.org> <74dfc79ede606f9424af2b0f564b01f3@mail.infomaniak.com> In-Reply-To: X-Infomaniak-Routing: alpha X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:29222, ipnet:2001:1600::/32, country:CH] X-Rspamd-Queue-Id: 4W5JSk2fR4z4mch --_=_swift_1718977344_af46be7226463506fb82fd1b251121a8_=_ Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2024-06-21T14:19:12.000+02:00, Thierry Thomas wr= ote: >=C2=A0Le=C2=A0ven.=C2=A021=C2=A0juin=C2=A024=C2=A0=C3=A0=C2= =A014:13:00=C2=A0+0200,=C2=A0Daniel=C2=A0Engberg=C2=A0 >=C2=A0 >=C2=A0=C2=A0=C3=A9crivait=C2=A0: >=C2=A0 >>= =C2=A0=C2=A0A=C2=A0bit=C2=A0cleaner=C2=A0and=C2=A0likely=C2=A0sustainable= =C2=A0solution=C2=A0would=C2=A0be=C2=A0to=C2=A0import >>=C2=A0=C2=A0the= >>=C2=A0=C2=A0 >>=C2=A0=C2=A0=C2=A0CMake=C2=A0build=C2=A0from=C2=A0Fed= ora/Macports=C2=A0which=C2=A0would=C2=A0likely=C2=A0remove=C2=A0all >>= =C2=A0=C2=A0the >>=C2=A0=C2=A0 >>=C2=A0=C2=A0=C2=A0manual=C2=A0workarou= nds=C2=A0for=C2=A0upstream's=C2=A0Makefile. >>=C2=A0=C2=A0 >>=C2=A0= =C2=A0=C2=A0https://src.fedoraproject.org/rpms/mathex/blob/rawhide/f/CMakeL= ists.txt >>=C2=A0=C2=A0 >>=C2=A0=C2=A0=C2=A0https://github.com/macports= /macports-ports/blob/master/math/mathex/files/CMakeLists.txt >=C2=A0 >= =C2=A0Well,=C2=A0cmake=C2=A0is=C2=A0rather=C2=A0heavy,=C2=A0and=C2=A0it= =C2=A0seems=C2=A0over-engineering=C2=A0to=C2=A0use=C2=A0it >=C2=A0for >= =C2=A0 >=C2=A0such=C2=A0a=C2=A0small=C2=A0library! >=C2=A0 >=C2=A0--= =C2=A0 >=C2=A0 >=C2=A0Th.=C2=A0Thomas. The only consumer (not link= ed?) uses CMake too so I don't see that much of a concern?=20 Here's a= poc with prefix(ed) examples,matching comment (there a typo) and pkg-des= cr (slightly altered). Plist is also fixed when EXAMPLES are disabled = (needs to be patched either way). https://projects.pyret.net/files/f= reebsd-patches/mathex-cmake.patch Best regards, Daniel --_=_swift_1718977344_af46be7226463506fb82fd1b251121a8_=_ Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable
On 2024-06-21T14:19:12.000+02:00, Thierry Thomas <thier= ry@freebsd.org> wrote:
Le ven. 21 juin 24 =C3=A0 14:13:00 +0200, Daniel Engberg <dan=
iel.engberg.lists@pyret.net>
 =C3=A9crivait :
=


  A bit cleaner=
 and likely sustainable solution would be to import the
 CMak=
e build from Fedora/Macports which would likely remove all the
 manual workarounds for upstream's Makefile.

https://src.fedoraproject.org/rpms/mathex/bl= ob/rawhide/f/CMakeLists.txt


Well, cmake is rather heavy, and it seems over-engineering= to use it for
such a small library!
--
Th. Thomas.
The only consume= r (not linked?) uses CMake too so I don't see that much of a concern?
<= /div>
Here's a poc with prefix(ed) examples,matching comment (there a t= ypo) and pkg-descr (slightly altered).
Plist is also fixed wh= en EXAMPLES are disabled (needs to be patched either way).

Best regards,
Dan= iel
--_=_swift_1718977344_af46be7226463506fb82fd1b251121a8_=_--