From owner-freebsd-current@FreeBSD.ORG  Thu May 26 12:12:18 2005
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
X-Original-To: freebsd-current@freebsd.org
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id BBAB316A43C;
	Thu, 26 May 2005 12:12:18 +0000 (GMT) (envelope-from avg@icyb.net.ua)
Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 5396043D5D;
	Thu, 26 May 2005 12:12:15 +0000 (GMT) (envelope-from avg@icyb.net.ua)
Received: from [212.40.38.87] (oddity-e.topspin.kiev.ua [212.40.38.87])
	by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id PAA25760;
	Thu, 26 May 2005 15:12:13 +0300 (EEST)
	(envelope-from avg@icyb.net.ua)
Message-ID: <4295BD1C.6020507@icyb.net.ua>
Date: Thu, 26 May 2005 15:12:12 +0300
From: Andriy Gapon <avg@icyb.net.ua>
User-Agent: Mozilla Thunderbird 1.0.2 (X11/20050328)
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: freebsd-stable@freebsd.org, freebsd-current@freebsd.org
References: <428C6489.3040609@icyb.net.ua> <429206BB.2050409@icyb.net.ua>
In-Reply-To: <429206BB.2050409@icyb.net.ua>
Content-Type: text/plain; charset=KOI8-U
Content-Transfer-Encoding: 7bit
Cc: 
Subject: Re: ad and da do not set interface type in devstat entry [Was: acd
 lacks devstat]
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 26 May 2005 12:12:19 -0000


On a devstat+disks related note:
I see that (scsi) cd device driver pre-creates devstat entry before
calling geom disk_create() and sets device type to
DEVSTAT_TYPE_CDROM|DEVSTAT_TYPE_IF_SCSI, which is perfect IMHO. On the
other hand, da and ad drivers rely on disk_create() to create a devstat
entry and it is created with device type DEVSTAT_TYPE_DIRECT, which is
not incorrect but is not complete either:
iostat -d -t SCSI or iostat -d -t IDE
wouldn't show any ad or da devices, only cd.

Btw, I have file a PR for acd not having devstat support:
http://www.freebsd.org/cgi/query-pr.cgi?pr=81496

-- 
Andriy Gapon