From owner-svn-src-head@freebsd.org Wed Dec 13 12:47:22 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D090AE9D2A2; Wed, 13 Dec 2017 12:47:22 +0000 (UTC) (envelope-from andrew@fubar.geek.nz) Received: from fry.fubar.geek.nz (fry.fubar.geek.nz [139.59.165.16]) by mx1.freebsd.org (Postfix) with ESMTP id A05116F535; Wed, 13 Dec 2017 12:47:22 +0000 (UTC) (envelope-from andrew@fubar.geek.nz) Received: from [IPv6:2001:630:212:2a8:c15a:e5b1:31ad:6576] (unknown [IPv6:2001:630:212:2a8:c15a:e5b1:31ad:6576]) by fry.fubar.geek.nz (Postfix) with ESMTPSA id BB5AA4EBCD; Wed, 13 Dec 2017 12:46:50 +0000 (UTC) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 11.1 \(3445.4.7\)) Subject: Re: svn commit: r326808 - head/sys/kern From: Andrew Turner In-Reply-To: <201712122015.vBCKFvNk047250@repo.freebsd.org> Date: Wed, 13 Dec 2017 12:46:49 +0000 Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <87732030-061F-43FB-94D7-4DB6F6558A4B@fubar.geek.nz> References: <201712122015.vBCKFvNk047250@repo.freebsd.org> To: Fedor Uporov X-Mailer: Apple Mail (2.3445.4.7) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Dec 2017 12:47:22 -0000 > On 12 Dec 2017, at 20:15, Fedor Uporov wrote: >=20 > Author: fsu > Date: Tue Dec 12 20:15:57 2017 > New Revision: 326808 > URL: https://svnweb.freebsd.org/changeset/base/326808 >=20 > Log: > Move buffer size checks outside of the vnode locks. >=20 > Reviewed by: kib, cem, pfg (mentor) > Approved by: pfg (mentor) > MFC after: 1 weeks >=20 > Differential Revision: https://reviews.freebsd.org/D13405 This breaks the build when MAC is undefined, e.g. the armv7 GENERIC = kernel. /usr/home/andrew/freebsd/repo/head-svn/sys/kern/vfs_extattr.c:201:1: = error: unused label 'done' [-Werror,-Wunused-label] done: ^~~~~ /usr/home/andrew/freebsd/repo/head-svn/sys/kern/vfs_extattr.c:376:1: = error: unused label 'done' [-Werror,-Wunused-label] done: ^~~~~ /usr/home/andrew/freebsd/repo/head-svn/sys/kern/vfs_extattr.c:677:1: = error: unused label 'done' [-Werror,-Wunused-label] done: ^~~~~ 3 errors generated. Andrew