From owner-svn-src-head@freebsd.org Wed Dec 20 20:07:25 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C232AEA14B3 for ; Wed, 20 Dec 2017 20:07:25 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound1b.ore.mailhop.org (outbound1b.ore.mailhop.org [54.200.247.200]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id A5F6D7FBC7 for ; Wed, 20 Dec 2017 20:07:25 +0000 (UTC) (envelope-from ian@freebsd.org) X-MHO-User: 5fc7c740-e5c1-11e7-8486-0934409070aa X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 73.78.92.27 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [73.78.92.27]) by outbound1.ore.mailhop.org (Halon) with ESMTPSA id 5fc7c740-e5c1-11e7-8486-0934409070aa; Wed, 20 Dec 2017 20:07:16 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id vBKK7MqZ001789; Wed, 20 Dec 2017 13:07:23 -0700 (MST) (envelope-from ian@freebsd.org) Message-ID: <1513800442.29087.28.camel@freebsd.org> Subject: Re: svn commit: r326991 - in head/sys/fs: nfs nfsclient From: Ian Lepore To: John Baldwin , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Date: Wed, 20 Dec 2017 13:07:22 -0700 In-Reply-To: <201712191918.vBJJImA5072223@repo.freebsd.org> References: <201712191918.vBJJImA5072223@repo.freebsd.org> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.1 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Dec 2017 20:07:25 -0000 On Tue, 2017-12-19 at 19:18 +0000, John Baldwin wrote: > Author: jhb > Date: Tue Dec 19 19:18:48 2017 > New Revision: 326991 > URL: https://svnweb.freebsd.org/changeset/base/326991 > > Log: >   Update NFS to handle larger link counts post ino64. > [...] > Modified: head/sys/fs/nfsclient/nfs_clvnops.c > ============================================================================== > --- head/sys/fs/nfsclient/nfs_clvnops.c Tue Dec 19 19:14:01 2017 (r326990) > +++ head/sys/fs/nfsclient/nfs_clvnops.c Tue Dec 19 19:18:48 2017 (r326991) > @@ -3450,7 +3450,7 @@ nfs_pathconf(struct vop_pathconf_args *ap) >    * For NFSv2 (or NFSv3 when not one of the above 4 a_names), >    * just fake them. >    */ > - pc.pc_linkmax = LINK_MAX; > + pc.pc_linkmax = NFS_LINK_MAX; >   pc.pc_namemax = NFS_MAXNAMLEN; >   pc.pc_notrunc = 1; >   pc.pc_chownrestricted = 1; > @@ -3460,7 +3460,7 @@ nfs_pathconf(struct vop_pathconf_args *ap) >   } >   switch (ap->a_name) { >   case _PC_LINK_MAX: > - *ap->a_retval = pc.pc_linkmax; > + *ap->a_retval = MIN(LONG_MAX, pc.pc_linkmax); I just noticed a build error on powerpc LINT and LINT64 kernels on this line: /b/staging/freebsd/head/src/sys/fs/nfsclient/nfs_clvnops.c:3464: warning: comparison is always false due to limited range of data type -- Ian