From nobody Mon Apr 27 21:15:09 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4g4GYT61kZz6bdnD for ; Mon, 27 Apr 2026 21:15:09 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4g4GYT4X8Hz3XrK for ; Mon, 27 Apr 2026 21:15:09 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1777324509; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=yCvKj9ZxR++tiD2w3W2i73w7ZBT/HzIujI1G/Z9w9tg=; b=V0+g1nw41n7ocE1rGR9t9RItGBQR58f6NveBQ1Y+6WOEiorO4ncXAoh4xWV9knu7L+AId5 RcgIkHyf1YOthO3eGLRkvFV7o9xciZ4xbSDaAW0dQkm18PLfA2e0umIGm6s7HoHB7/OAYd 7I5+txBBolr4Ll173gaoCtzSNuhZjx1FUFEvPjHlM5vGboo677iuZ+wI2Wjzgv0oIiwPLd k5Sz6XcAsTAtX/0iNCdo/2jNqwHm5fjsO+D8uGGeosjBqrojKYR9UegnykCYfLPqCXVajc goswo1XKiH/avioFczEw00dXWitGM7GRuTLb+6M9Zp67hyJCQlc688C7EXGDNA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1777324509; a=rsa-sha256; cv=none; b=SPtOqlnTxCBEpL33QOwaiAHjDyAHv2Sqi/2+gFTeyERkWSNfl5D9qi3pEhZsKP7OyccgXX foDq0rQu0Nqoau1VEqgXSVWR2wy4v8rn6KXE8vOOIe4MILsOjuYmpDWoPX+c7kp3YTzr9o OvRaNElM3SkFQ2zCoNWwH5T1cQ29UCqTjkEOQ/YZDUOx/SLo2p9hZG4yZQbgBdWZFjDNQB pl+ZjiB5RJp47o209Hmjpj7KvNDyJECVH6d4tclx3AJbt3W8aDGvrVH1V85ouwubvS842/ Ahf4H6Bfxm+3DirfdaoADZeOsWcQKNwiYxS2V9U1pZur9jPMmeizuu9umlqFAA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1777324509; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=yCvKj9ZxR++tiD2w3W2i73w7ZBT/HzIujI1G/Z9w9tg=; b=n/Qbt+w6WYz+3YpY5EkETg1Qh5CvtTBxCKohyydBFRg4+jYjH/3QeUjRxaEQ22s5TNBj6x zQzo7gHsaHSpagwnd8KSM9gYQK+TFJnxolodSvTXeouYnqUzmGO2Sed69YtDFf1Mxzpg6O YPtNU/JCttcysk1Ek5OIP43pK8kLHI4YDlChRhsB7rbXVqgLhSAr6frFhpOZfWBgwZXpE9 RqSyG1Cy7F4cN+FbG2KrVfvYGjxsgwlS8qiyQVBdL9U3M4c0fS9rZP0r1lAJA9zYUBQc8H IBURDyV2uGaYFdJG8Tmj+pSt9tYKg+SJLBSrJw8wCYbwTuWsznNh8Ww98z1Fmg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4g4GYT44lkz8VL for ; Mon, 27 Apr 2026 21:15:09 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3b0e5 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 27 Apr 2026 21:15:09 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Cc: David Arinzon From: Arthur Kiyanovski Subject: git: e3f4a63af63b - main - ena: Report RX overrun errors List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: akiyano X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: e3f4a63af63bea70bc86b6c790b14aa5ee99fcd0 Auto-Submitted: auto-generated Date: Mon, 27 Apr 2026 21:15:09 +0000 Message-Id: <69efd1dd.3b0e5.5dfd1c46@gitrepo.freebsd.org> The branch main has been updated by akiyano: URL: https://cgit.FreeBSD.org/src/commit/?id=e3f4a63af63bea70bc86b6c790b14aa5ee99fcd0 commit e3f4a63af63bea70bc86b6c790b14aa5ee99fcd0 Author: David Arinzon AuthorDate: 2026-04-15 12:13:56 +0000 Commit: Arthur Kiyanovski CommitDate: 2026-04-27 21:13:53 +0000 ena: Report RX overrun errors Extract rx_overruns from the keep alive descriptor reported by the device and expose it via sysctl hw stats. RX overrun errors occur when a packet arrives but there are not enough free buffers in the RX ring to receive it. MFC after: 2 weeks Sponsored by: Amazon, Inc. Differential Revision: https://reviews.freebsd.org/D56640 --- sys/dev/ena/ena.c | 4 ++++ sys/dev/ena/ena.h | 2 ++ sys/dev/ena/ena_sysctl.c | 2 ++ 3 files changed, 8 insertions(+) diff --git a/sys/dev/ena/ena.c b/sys/dev/ena/ena.c index 6972c71bd67c..4f45d9103d76 100644 --- a/sys/dev/ena/ena.c +++ b/sys/dev/ena/ena.c @@ -3090,15 +3090,19 @@ ena_keep_alive_wd(void *adapter_data, struct ena_admin_aenq_entry *aenq_e) sbintime_t stime; uint64_t rx_drops; uint64_t tx_drops; + uint64_t rx_overruns; desc = (struct ena_admin_aenq_keep_alive_desc *)aenq_e; rx_drops = ((uint64_t)desc->rx_drops_high << 32) | desc->rx_drops_low; tx_drops = ((uint64_t)desc->tx_drops_high << 32) | desc->tx_drops_low; + rx_overruns = ((uint64_t)desc->rx_overruns_high << 32) | desc->rx_overruns_low; counter_u64_zero(adapter->hw_stats.rx_drops); counter_u64_add(adapter->hw_stats.rx_drops, rx_drops); counter_u64_zero(adapter->hw_stats.tx_drops); counter_u64_add(adapter->hw_stats.tx_drops, tx_drops); + counter_u64_zero(adapter->hw_stats.rx_overruns); + counter_u64_add(adapter->hw_stats.rx_overruns, rx_overruns); stime = getsbinuptime(); atomic_store_rel_64(&adapter->keep_alive_timestamp, stime); diff --git a/sys/dev/ena/ena.h b/sys/dev/ena/ena.h index b2156437f847..8b5bcdc3214f 100644 --- a/sys/dev/ena/ena.h +++ b/sys/dev/ena/ena.h @@ -417,6 +417,8 @@ struct ena_hw_stats { counter_u64_t rx_drops; counter_u64_t tx_drops; + + counter_u64_t rx_overruns; }; /* Board specific private data structure */ diff --git a/sys/dev/ena/ena_sysctl.c b/sys/dev/ena/ena_sysctl.c index 38e52f9066cc..a46119e06adf 100644 --- a/sys/dev/ena/ena_sysctl.c +++ b/sys/dev/ena/ena_sysctl.c @@ -419,6 +419,8 @@ ena_sysctl_add_stats(struct ena_adapter *adapter) &hw_stats->rx_drops, "Receive packet drops"); SYSCTL_ADD_COUNTER_U64(ctx, hw_list, OID_AUTO, "tx_drops", CTLFLAG_RD, &hw_stats->tx_drops, "Transmit packet drops"); + SYSCTL_ADD_COUNTER_U64(ctx, hw_list, OID_AUTO, "rx_overruns", CTLFLAG_RD, + &hw_stats->rx_overruns, "Receive overruns"); /* ENA Admin queue stats */ admin_node = SYSCTL_ADD_NODE(ctx, child, OID_AUTO, "admin_stats",