From owner-freebsd-standards Wed Jan 30 13:41:23 2002 Delivered-To: freebsd-standards@freebsd.org Received: from mail.rpi.edu (mail.rpi.edu [128.113.22.40]) by hub.freebsd.org (Postfix) with ESMTP id 30A0437B400 for ; Wed, 30 Jan 2002 13:41:21 -0800 (PST) Received: from [128.113.24.47] (gilead.acs.rpi.edu [128.113.24.47]) by mail.rpi.edu (8.11.3/8.11.3) with ESMTP id g0ULf6J84116; Wed, 30 Jan 2002 16:41:06 -0500 Mime-Version: 1.0 X-Sender: drosih@mail.rpi.edu Message-Id: In-Reply-To: <20020130201615.A9151@descent.robbins.dropbear.id.au> References: <20020130201615.A9151@descent.robbins.dropbear.id.au> Date: Wed, 30 Jan 2002 16:41:04 -0500 To: "Tim J. Robbins" , freebsd-standards@FreeBSD.ORG From: Garance A Drosihn Subject: Re: fold -b and -s options patch Content-Type: text/plain; charset="us-ascii" ; format="flowed" X-Scanned-By: MIMEDefang 2.3 (www dot roaringpenguin dot com slash mimedefang) Sender: owner-freebsd-standards@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG At 8:16 PM +1100 1/30/02, Tim J. Robbins wrote: >This patch adds the -b and -s options to fold. It's mostly taken from >NetBSD but I've hopefully kept it compilable by K&R compilers. If you're picking up code from NetBSD or OpenBSD, then you certainly do not need to add __P()'s to it. FreeBSD developers have repeatedly decided that we should also move to ANSI instead of K&R, even though there are a few holdouts who seem to believe that no such agreement has been reached. One justification for *keeping* __P()'s is to be compatible with source from the other BSD's, and in this case even that argument would say that __P()'s should not be added. [this is just a minor comment on your changes though, obviously it's good that you're trying to chip away at the list of programs we want to update to the latest standards!] -- Garance Alistair Drosehn = gad@eclipse.acs.rpi.edu Senior Systems Programmer or gad@freebsd.org Rensselaer Polytechnic Institute or drosih@rpi.edu To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-standards" in the body of the message