From nobody Wed Sep 3 17:10:23 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cH8Hz6Nvnz66klJ; Wed, 03 Sep 2025 17:10:23 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cH8Hz5BtGz3CH8; Wed, 03 Sep 2025 17:10:23 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1756919423; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=72c13hJtRzbJIBBLa7FkBbFOtxYdkneI0Z3CbfRIlOE=; b=Zr03oBtK99YKma+XcYhriOQqO56I/Jm7vpHbOIDXtWo8LkfItEY3tJtfCLtX1w4Vf5iZCE 74uTT8AeXzdkBqWFOCRx0h79+Wu/oqvTSGBmknWn/f+HaIXGBiDQ5XOGMN6JpMlKZia74y PGYfNIUshuWbBS18bkMT9UCXMlNGbRxHLq4avh2h/18dpfW5M4dI/7AAoOCRJhYhIaW6Gx WrDlH5r7y5w5EZJUkrob9P/BmH5ynBS4mR1roxhKMd9pXMsM+PJUesqAa9SFjTI/EMjXQK Mxl/GKeimaJXGWco3YKer6Gx0hNZV24tFsZg+Cik2k8nKm6O0Fvf+j2dpLx7xw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1756919423; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=72c13hJtRzbJIBBLa7FkBbFOtxYdkneI0Z3CbfRIlOE=; b=FDs7hstJ2k91JmkT6EHH/KuqespoGo5uqaXygoEJFzqOmxoQEMYg7bmvN5EpPHCRvKRzKd khlzdMXOKoti/KUliYgpEYoJMrBtCMkOZjy5oN1QZHT5rOkt8sflLmZ7QrqogZ+bguE+gf CkDSFXWuT0y95Ba+dCAwslkr2B+T7yOHP0zqqRy1qveZkRs4qPPZKEU7ecWvJYINEyMioq RUKkx6AK3iok4f01WmTctj2dUK8v+lyOqAOxE31haq/yA4dsjWzSVQn2TtPagu/e73jhD1 fGx1zo3KM3UXa1S/dhds3c/WCMk1GTnQIyRYbxXvvJ94ySyYrVmiMnP96/nZQg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1756919423; a=rsa-sha256; cv=none; b=tCos1/ePePvQPqDzQIbczod9/hd5LjUKrCXPRODY3M6bBHHLGPSRzgXh0LrEmh6JNpoCu4 pYbEqU7DvgIqUfQ/vmXp30JmHxCGO9rIb4Dnr0sNbUVedVi4SLLicp17ykdjBso8tGETRT NQAqLqgssCdz9rPE1ExBat0Ur1/Pg3pIlS+kqtVPRAuW5TzSqz/1kmazIBn308A23dY0gZ O4PenzWsebwkNR9u3RxVos+tiOURAiPFCj5neG0tsUXUc4oVJLR7IPPROymni5UxeTgKHV bIcQAxGdUM0j5B+a+VPlylqxBWrVGc2bPk2KNycC1HgGhNPvmVRa2LSHMl97wA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cH8Hz4pFPz9JL; Wed, 03 Sep 2025 17:10:23 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 583HANFX001611; Wed, 3 Sep 2025 17:10:23 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 583HANEc001607; Wed, 3 Sep 2025 17:10:23 GMT (envelope-from git) Date: Wed, 3 Sep 2025 17:10:23 GMT Message-Id: <202509031710.583HANEc001607@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Zhenlei Huang Subject: git: 51098f0529f0 - main - ethernet: Prefer memcmp() over bcmp() List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: zlei X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 51098f0529f0d1cc532512e0eae9bfcffb8e68e4 Auto-Submitted: auto-generated The branch main has been updated by zlei: URL: https://cgit.FreeBSD.org/src/commit/?id=51098f0529f0d1cc532512e0eae9bfcffb8e68e4 commit 51098f0529f0d1cc532512e0eae9bfcffb8e68e4 Author: Zhenlei Huang AuthorDate: 2025-09-03 17:09:11 +0000 Commit: Zhenlei Huang CommitDate: 2025-09-03 17:09:11 +0000 ethernet: Prefer memcmp() over bcmp() The link-level address and the mbuf shall not overlap. Prefer memcmp() over bcmp() for slight performance gain. No functional change intended. Reviewed by: glebius MFC after: 2 weeks Differential Revision: https://reviews.freebsd.org/D52345 --- sys/net/if_ethersubr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/net/if_ethersubr.c b/sys/net/if_ethersubr.c index 3ae0c01c0efc..9c157bf3d3c2 100644 --- a/sys/net/if_ethersubr.c +++ b/sys/net/if_ethersubr.c @@ -695,7 +695,7 @@ ether_input_internal(struct ifnet *ifp, struct mbuf *m) * seen by upper protocol layers. */ if (!ETHER_IS_MULTICAST(eh->ether_dhost) && - bcmp(IF_LLADDR(ifp), eh->ether_dhost, ETHER_ADDR_LEN) != 0) + memcmp(IF_LLADDR(ifp), eh->ether_dhost, ETHER_ADDR_LEN) != 0) m->m_flags |= M_PROMISC; }