Date: Thu, 21 Dec 2000 06:10:32 -0800 (PST) From: stolz@i2.informatik.rwth-aachen.de To: freebsd-gnats-submit@FreeBSD.org Subject: bin/23712: Unused variable CDB in /usr/src/usr.sbin/pw/Makefile Message-ID: <200012211410.eBLEAW873687@freefall.freebsd.org> Resent-Message-ID: <200012211420.eBLEK1L74673@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 23712 >Category: bin >Synopsis: Unused variable CDB in /usr/src/usr.sbin/pw/Makefile >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Thu Dec 21 06:20:00 PST 2000 >Closed-Date: >Last-Modified: >Originator: Volker Stolz >Release: 4.2-STABLE >Organization: >Environment: FreeBSD monster.ikea.net 4.2-STABLE FreeBSD 4.2-STABLE #0: Wed Nov 29 14:54:28 CET 2000 vs@monster.ikea.net:/usr/src/sys/compile/MONSTER i386 >Description: /usr/src/usr.sbin/pw/Makefile includes the uninitialized variable CDB into CFLAGS: #RND= -DUSE_MD5RAND CFLAGS+= -W -Wall $(CDB) $(RND) This will lead to problems when the user invoking make (e.g. on ´make world´) has set this particular variable in his environment. It should be set to a reasonable default (empty: "") or be dropped altogether. On a related note, the assignment to RND in the same Makefile is commented out. To avoid the same problem as mentioned above with CDB it should at least be set to "". >How-To-Repeat: Enter /usr/src/usr.sbin/pw, set CDB or RND to some arbitrary value, invoke make. >Fix: Two possible solutions for CDB: 1) Drop it from the Makefile 2) Set it to "" For RND: Set to "". >Release-Note: >Audit-Trail: >Unformatted: To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200012211410.eBLEAW873687>