From owner-freebsd-current@FreeBSD.ORG Wed Oct 8 17:27:49 2003 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8DA4416A4B3; Wed, 8 Oct 2003 17:27:49 -0700 (PDT) Received: from mail.pcnet.com (mail.pcnet.com [204.213.232.4]) by mx1.FreeBSD.org (Postfix) with ESMTP id C1AD843FE5; Wed, 8 Oct 2003 17:27:48 -0700 (PDT) (envelope-from eischen@vigrid.com) Received: from mail.pcnet.com (mail.pcnet.com [204.213.232.4]) by mail.pcnet.com (8.12.10/8.12.1) with ESMTP id h990RlgG003201; Wed, 8 Oct 2003 20:27:47 -0400 (EDT) Date: Wed, 8 Oct 2003 20:27:47 -0400 (EDT) From: Daniel Eischen X-Sender: eischen@pcnet5.pcnet.com To: current@freebsd.org Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: sam@freebsd.org Subject: if_em panic X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: deischen@freebsd.org List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Oct 2003 00:27:49 -0000 One of my buddies is having panics with if_em after the last set of changes a couple of weeks ago. He runs dhclient on the interface to get a lease from a cable modem. The panic is a recurse on a non-recursive mutex. I haven't gotten a traceback from him yet, but a little perusing through the source seems to show this as a possible problem: Index: if_em.c =================================================================== RCS file: /opt/FreeBSD/cvs/src/sys/dev/em/if_em.c,v retrieving revision 1.30 diff -u -r1.30 if_em.c --- if_em.c 23 Sep 2003 00:18:25 -0000 1.30 +++ if_em.c 8 Oct 2003 20:12:56 -0000 @@ -933,7 +933,7 @@ if (ether_poll_register(em_poll, ifp)) { em_disable_intr(adapter); - em_poll(ifp, 0, 1); + em_poll_locked(ifp, 0, 1); EM_UNLOCK(adapter); return; } Also, indentation is inconsistent, some lines use tabs, some uses spaces. It looks like the original code from Intel used spaces and subsequent mods used tabs. I guess we should be sticking with the original style, but it is easy to overlook. -- Dan Eischen