Date: Wed, 29 Oct 2014 09:29:04 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 194679] New: [patch] irc/irc:builds forever if uname -a doesn't match CONFIGURE_TARGET Message-ID: <bug-194679-13@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=194679 Bug ID: 194679 Summary: [patch] irc/irc:builds forever if uname -a doesn't match CONFIGURE_TARGET Product: Ports Tree Version: Latest Hardware: Any OS: Any Status: Needs Triage Severity: Affects Only Me Priority: --- Component: Individual Port(s) Assignee: johans@FreeBSD.org Reporter: marino@FreeBSD.org Assignee: johans@FreeBSD.org Flags: maintainer-feedback?(johans@FreeBSD.org) Created attachment 148757 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=148757&action=edit IRC makefile patch The IRC configure script has curious logic. All it really wants to do is create a build directory and run a different configure script there. Rather than just use a fixed name for the build directory, it uses a name based on the triplet of the host machine. This is reflected in the port makefile with the line "BUILD_WRKSRC= ${WRKSRC}/${MACHINE_ARCH}-unknown-${OPSYS:tl}${OSREL}" Besides being overly complex, it actually breaks badly if the port is being built in a chroot where the host triplet won't match the jail triplet. Attached in a log showing make running forever after hitting a "cd" error, which in itself is a bug. The solution I've provided here is clean. Using the pre-configure target, the build directory (with a fixed name) is created and the needed configure script and header are copied over, just like the top configure script does. Then the port makefile just configures with that. It's much better, more robust, and fixes the triplet mismatch. Please review and hopefully approve the patch for commit. --- Comment #1 from Bugzilla Automation <bugzilla@FreeBSD.org> --- Auto-assigned to maintainer johans@FreeBSD.org -- You are receiving this mail because: You are the assignee for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-194679-13>