Date: Mon, 6 Jul 2020 11:25:44 +0400 From: Gleb Popov <6yearold@gmail.com> To: "Tobias C. Berner" <tcberner@freebsd.org> Cc: Alexey Dokuchaev <danfe@freebsd.org>, ports-committers <ports-committers@freebsd.org>, svn-ports-all <svn-ports-all@freebsd.org>, svn-ports-head <svn-ports-head@freebsd.org> Subject: Re: svn commit: r541296 - in head: databases/kexi devel/injeqt textproc/libkolabxml x11/sddm Message-ID: <CALH631=ZugswyONhqcV8jawdO_N2p2EK2rNt2oMWiuO6=RzDoQ@mail.gmail.com> In-Reply-To: <CAOshKtcu3i9WYg_o2W_oBnwGG0Drh=VCPt%2B0E_MaPt_=pnjJog@mail.gmail.com> References: <202007051920.065JKLK1093017@repo.freebsd.org> <20200705192642.GA32791@FreeBSD.org> <CAOshKtcu3i9WYg_o2W_oBnwGG0Drh=VCPt%2B0E_MaPt_=pnjJog@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Jul 6, 2020 at 1:44 AM Tobias C. Berner <tcberner@freebsd.org> wrote: > Well, I disagree. I find it exactly the opposite :) > +1, CMAKE_ON gets parsed by my brain faster than -DBUILD_MAN_PAGES=ON > > mfg Tobias > > On Sun, 5 Jul 2020 at 21:26, Alexey Dokuchaev <danfe@freebsd.org> wrote: > > > > On Sun, Jul 05, 2020 at 07:20:21PM +0000, Tobias C. Berner wrote: > > > New Revision: 541296 > > > URL: https://svnweb.freebsd.org/changeset/ports/541296 > > > > > > Log: > > > Switch to using CMAKE_ON/CMAKE_OFF instead of more clunky CMAKE_ARGS > > > > > > Modified: head/x11/sddm/Makefile > > > ... > > > +CMAKE_ON= BUILD_MAN_PAGES > > > CMAKE_ARGS= -DUID_MIN=1000 \ > > > -DUID_MAX=65000 \ > > > -DCMAKE_INSTALL_SYSCONFDIR:PATH=${LOCALBASE}/etc \ > > > - -DBUILD_MAN_PAGES=ON \ > > > > -DRST2MAN_EXECUTABLE=${LOCALBASE}/bin/rst2man.py-${PYTHON_VER} > > > > This one looks like pessimization. Please be more considerate with these > > changes; I, for one, do not like CMAKE_ON/OFF as I find it harder to read > > and understand and prefer explicit assignments via CMAKE_ARGS. > > > > ./danfe >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CALH631=ZugswyONhqcV8jawdO_N2p2EK2rNt2oMWiuO6=RzDoQ>