From nobody Tue Mar 3 23:16:52 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fQWsJ4yn6z6TmfZ for ; Tue, 03 Mar 2026 23:16:52 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fQWsJ1mkgz45Bg for ; Tue, 03 Mar 2026 23:16:52 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1772579812; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=uJMFFTgP36fAEKULXE1T8ARly2Ozz3LHCkf3DeUGW6Y=; b=hlnm1aFzjSZH7fU1en6G2OBT4dy543QNcYmyPf3kSviG2WK1l4A+EOu73nG3A1lRldGEZh J50JEInfuPc5r1ckW0tG9r6Q3UBD7D/Vo410djZrHGNijVgZTqTgOmhBw9sExA5aUq24dF MHw6s3XnMIINVq8KhY/Fb2+CmAO3dILxE9lw2lNxBLvc5/Tq+hSFzytpL14ybY/qsM9Ja1 oo9wCDLBSbmMFXUhJr/cs/B7vw3jprBUZzTqtyMCc/jWQFSgjgmDUW6de/PvoQlkmyirfS r74OMc3dJWHWGSj2KkhwOJ7CpenVy8XHuf7Vy/u9ZCEQpqQMkpMAfxoOETI8sA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1772579812; a=rsa-sha256; cv=none; b=q8v81GP3gvca5/Oacz55e7mV70Hkv4ZVv2CgJUxwKHrIZ2AAZcGY7hNPbESjYmSTvB/IxF OPk9I5IGqW5vUzpLqUJGrPy70MHSX43Jxv9qCugJlGzeF5Xxzm4F+Wm8mMTlO5KEARK8ze ZR90rPITED19rCBosP0elhtiHKHkklqzUDH3hgsjWGaaGPeHquKG/peuHkkUP0unuJAysQ Jpwwe+BBZg5rhWa4YCTLyxKbDWpTGJPFdt9q1zjTDz5pNJLzJWtFFNqTa7sBUPJmb94O/y 3No72a03dvlcd/f3QqkP9BhKP/ZfoEkwlPXXovxmZRr+hdlzLRdsjuUBqIVuXQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1772579812; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=uJMFFTgP36fAEKULXE1T8ARly2Ozz3LHCkf3DeUGW6Y=; b=W8bhZBbGYuzLbzXt3BzhB2Ugi36HlVLE3N34ulNw1TryyVUNUa15Z+urUfmqeQkPhPrLq/ VN2f3GOQIbiRiZeWTADimxI3+DlHMCfNFfL3nRSh/63p1qQU9kA7JOB+YrZzsZwQmpno2L USaVwciq81PL1uFWQFGj5oulh2991lujqHKmkpLRqa7bpAnAzy/Pw5M5lDqOJdeEZNW29V R1lCyLAAmooX5XgeYv4x7RU92tkHXxE9uiIhC2ZWs+ubv7dpIBCp9Aaqm5BeU2DRs8zlQd prKbM1HIoAdmb8mrMlsh4crCxnMCpkd9hG/FJjxwTLJZgzYP4kNriFuE/vSvhw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fQWsJ0szhz8t2 for ; Tue, 03 Mar 2026 23:16:52 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3c1ab by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 03 Mar 2026 23:16:52 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Olivier Cochard Subject: git: 4d876fc5fc42 - main - acpi_spmc: fix revision check reading name as integer List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: olivier X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 4d876fc5fc427f9e4a110da5cc2ce62a21998b6c Auto-Submitted: auto-generated Date: Tue, 03 Mar 2026 23:16:52 +0000 Message-Id: <69a76be4.3c1ab.43a6fdf3@gitrepo.freebsd.org> The branch main has been updated by olivier: URL: https://cgit.FreeBSD.org/src/commit/?id=4d876fc5fc427f9e4a110da5cc2ce62a21998b6c commit 4d876fc5fc427f9e4a110da5cc2ce62a21998b6c Author: Olivier Cochard AuthorDate: 2026-03-03 23:05:04 +0000 Commit: Olivier Cochard CommitDate: 2026-03-03 23:08:23 +0000 acpi_spmc: fix revision check reading name as integer In acpi_spmc_get_constraints_spec(), the revision of the device constraint detail package was mistakenly read from constraint_obj->Package.Elements[0], which is the device name (a string), instead of from the detail sub-package's first element. Move the initialisation of 'detail' before the revision check and read the revision from detail->Package.Elements[0] as the comment already states Approved by: obiwac Differential Revision: https://reviews.freebsd.org/D55639 Sponsored by: Netflix --- sys/dev/acpica/acpi_spmc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/dev/acpica/acpi_spmc.c b/sys/dev/acpica/acpi_spmc.c index e8ed14fdcb1b..6b4363bb364d 100644 --- a/sys/dev/acpica/acpi_spmc.c +++ b/sys/dev/acpica/acpi_spmc.c @@ -322,11 +322,12 @@ acpi_spmc_get_constraints_spec(struct acpi_spmc_softc *sc, ACPI_OBJECT *object) return (ENOMEM); } + detail = &constraint_obj->Package.Elements[2]; /* * The first element in the device constraint detail package is * the revision, and should always be zero. */ - revision = constraint_obj->Package.Elements[0].Integer.Value; + revision = detail->Package.Elements[0].Integer.Value; if (revision != 0) { device_printf(sc->dev, "Unknown revision %d for " "device constraint detail package\n", revision); @@ -334,7 +335,6 @@ acpi_spmc_get_constraints_spec(struct acpi_spmc_softc *sc, ACPI_OBJECT *object) continue; } - detail = &constraint_obj->Package.Elements[2]; constraint_package = &detail->Package.Elements[1]; constraint->lpi_uid =