From owner-cvs-all Mon Nov 25 16:20:13 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A614E37B404; Mon, 25 Nov 2002 16:20:11 -0800 (PST) Received: from wantadilla.lemis.com (wantadilla.lemis.com [192.109.197.80]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8F57E43ECD; Mon, 25 Nov 2002 16:20:09 -0800 (PST) (envelope-from grog@lemis.com) Received: by wantadilla.lemis.com (Postfix, from userid 1004) id 94AEE51916; Tue, 26 Nov 2002 10:50:07 +1030 (CST) Date: Tue, 26 Nov 2002 10:50:07 +1030 From: Greg 'groggy' Lehey To: Bruce Evans Cc: Julian Elischer , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sbin/fsck_ffs pass5.c Message-ID: <20021126002007.GZ41068@wantadilla.lemis.com> References: <200211242141.gAOLfgKf007413@repoman.freebsd.org> <20021125165825.R55700-100000@gamplex.bde.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20021125165825.R55700-100000@gamplex.bde.org> User-Agent: Mutt/1.4i Organization: The FreeBSD Project Phone: +61-8-8388-8286 Fax: +61-8-8388-8725 Mobile: +61-418-838-708 WWW-Home-Page: http://www.FreeBSD.org/ X-PGP-Fingerprint: 9A1B 8202 BCCE B846 F92F 09AC 22E6 F290 507A 4223 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Monday, 25 November 2002 at 17:00:03 +1100, Bruce Evans wrote: > On Sun, 24 Nov 2002, Julian Elischer wrote: > >> julian 2002/11/24 13:41:42 PST >> >> Modified files: >> sbin/fsck_ffs pass5.c >> Log: >> Fsck needs to check each CG's rotor values to ensure thay are not -ve. >> It seems a common corruption to have them -ve (I've seen it several times) >> and if fsck doesn't fix it, it leads to a kernel pagefault. >> >> Reviewd by: kirk >> Submitted by: Eric Jacobs and me independently. >> MFC in: 2 days > > Please fix the style bugs (excessive parentheses) in this before merging. I thought there was consensus that additional parentheses were not necessarily a Bad Thing if they served to demonstrate operator precedence, as here. Greg -- See complete headers for address and phone numbers To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message