Date: Tue, 26 Nov 2002 10:50:07 +1030 From: Greg 'groggy' Lehey <grog@FreeBSD.org> To: Bruce Evans <bde@zeta.org.au> Cc: Julian Elischer <julian@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sbin/fsck_ffs pass5.c Message-ID: <20021126002007.GZ41068@wantadilla.lemis.com> In-Reply-To: <20021125165825.R55700-100000@gamplex.bde.org> References: <200211242141.gAOLfgKf007413@repoman.freebsd.org> <20021125165825.R55700-100000@gamplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Monday, 25 November 2002 at 17:00:03 +1100, Bruce Evans wrote: > On Sun, 24 Nov 2002, Julian Elischer wrote: > >> julian 2002/11/24 13:41:42 PST >> >> Modified files: >> sbin/fsck_ffs pass5.c >> Log: >> Fsck needs to check each CG's rotor values to ensure thay are not -ve. >> It seems a common corruption to have them -ve (I've seen it several times) >> and if fsck doesn't fix it, it leads to a kernel pagefault. >> >> Reviewd by: kirk >> Submitted by: Eric Jacobs <eaja@erols.com> and me independently. >> MFC in: 2 days > > Please fix the style bugs (excessive parentheses) in this before merging. I thought there was consensus that additional parentheses were not necessarily a Bad Thing if they served to demonstrate operator precedence, as here. Greg -- See complete headers for address and phone numbers To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20021126002007.GZ41068>