From owner-cvs-src@FreeBSD.ORG Tue Oct 16 21:27:54 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7270916A417; Tue, 16 Oct 2007 21:27:54 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from speedfactory.net (mail6.speedfactory.net [66.23.216.219]) by mx1.freebsd.org (Postfix) with ESMTP id CEB3813C461; Tue, 16 Oct 2007 21:27:53 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from server.baldwin.cx (unverified [66.23.211.162]) by speedfactory.net (SurgeMail 3.8p) with ESMTP id 214735023-1834499 for multiple; Tue, 16 Oct 2007 17:29:54 -0400 Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.8/8.13.8) with ESMTP id l9GLRaPp095469; Tue, 16 Oct 2007 17:27:46 -0400 (EDT) (envelope-from jhb@FreeBSD.org) From: John Baldwin To: Alexander Leidinger Date: Tue, 16 Oct 2007 17:26:31 -0400 User-Agent: KMail/1.9.6 References: <1947.1192477927@critter.freebsd.dk> <20071016183311.lu97hbwzggsk4ow4@webmail.leidinger.net> In-Reply-To: <20071016183311.lu97hbwzggsk4ow4@webmail.leidinger.net> MIME-Version: 1.0 Content-Disposition: inline Message-Id: <200710161726.32718.jhb@freebsd.org> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Tue, 16 Oct 2007 17:27:46 -0400 (EDT) X-Virus-Scanned: ClamAV 0.88.3/4540/Sat Oct 13 21:43:55 2007 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: Wilko Bulte , Poul-Henning Kamp , src-committers@FreeBSD.org, cvs-all@FreeBSD.org, cvs-src@FreeBSD.org Subject: Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/share/man/man9 Makefile sensor_attach.9 src/sys/conf files ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2007 21:27:54 -0000 On Tuesday 16 October 2007 12:33:11 pm Alexander Leidinger wrote: > Constantine asked for review several times on -current. He got some > reviews several times for commits to perforce. He incorporated > suggestions from those reviews, or explained why it is like it is and > why he can not switch (with no replies with suggestions how to solve > the problems he sees with the suggestions). Now you come and ask why > nobody pointed out some flaws before (without telling us which > technical flaws you talk about). At least from my point of view this is not quite accurate as pretty much all my feedback to the p4 commits was ignored with basically "Well, I don't like doing it that way". Specifically, with regards to creating dynamic sysctl trees, Constantine feels that sysctl_add_oid(9) is a hack rather than recognizing that this is a feature of FreeBSD's sysctl system despite repeated e-mails on the subject. -- John Baldwin