From owner-freebsd-fs@freebsd.org  Mon Jan 18 12:31:36 2016
Return-Path: <owner-freebsd-fs@freebsd.org>
Delivered-To: freebsd-fs@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8DB0AA87A82
 for <freebsd-fs@mailman.ysv.freebsd.org>; Mon, 18 Jan 2016 12:31:36 +0000 (UTC)
 (envelope-from ronald-lists@klop.ws)
Received: from smarthost1.greenhost.nl (smarthost1.greenhost.nl
 [195.190.28.81]) (using TLSv1 with cipher AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 57B471963
 for <freebsd-fs@freebsd.org>; Mon, 18 Jan 2016 12:31:35 +0000 (UTC)
 (envelope-from ronald-lists@klop.ws)
Received: from smtp.greenhost.nl ([213.108.104.138])
 by smarthost1.greenhost.nl with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16)
 (Exim 4.72) (envelope-from <ronald-lists@klop.ws>)
 id 1aL8iS-00078j-M3
 for freebsd-fs@freebsd.org; Mon, 18 Jan 2016 13:15:29 +0100
Content-Type: text/plain; charset=utf-8; format=flowed; delsp=yes
To: freebsd-fs@freebsd.org
Subject: Re: [Bug 206328] Crash on shutdown with swap on NFS file (with patch)
References: <bug-206328-3630@https.bugs.freebsd.org/bugzilla/>
 <bug-206328-3630-prHGdYMqZV@https.bugs.freebsd.org/bugzilla/>
Date: Mon, 18 Jan 2016 13:15:22 +0100
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
From: "Ronald Klop" <ronald-lists@klop.ws>
Message-ID: <op.ybfobwktkndu52@ronaldradial.radialsg.local>
In-Reply-To: <bug-206328-3630-prHGdYMqZV@https.bugs.freebsd.org/bugzilla/>
User-Agent: Opera Mail/1.0 (Win32)
X-Authenticated-As-Hash: 398f5522cb258ce43cb679602f8cfe8b62a256d1
X-Virus-Scanned: by clamav at smarthost1.samage.net
X-Spam-Level: --
X-Spam-Score: -2.9
X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,
 BAYES_00 autolearn=disabled version=3.4.0
X-Scan-Signature: 51a43cd7ff6838d9e9bce89dbcde6c26
X-BeenThere: freebsd-fs@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Filesystems <freebsd-fs.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-fs>,
 <mailto:freebsd-fs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-fs/>
List-Post: <mailto:freebsd-fs@freebsd.org>
List-Help: <mailto:freebsd-fs-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
 <mailto:freebsd-fs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 18 Jan 2016 12:31:36 -0000

On Mon, 18 Jan 2016 10:48:10 +0100, <bugzilla-noreply@freebsd.org> wrote:

> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=206328
>
> --- Comment #3 from Tom Vijlbrief <tvijlbrief@gmail.com> ---
> bufshutdown() ends with:
>
>
>                 if (panicstr == NULL)
>                         vfs_unmountall();
>         }
>         swapoff_all();
>
> Why not just reverse the order?
>
> So swapoff_all() before the vfs_unmountall(), so that the NFS filesystem  
> is
> still available.
>
> Perhaps even at the start of bufshutdown().
>
> Still wondering what the reason of a swapoff_all() call just before the  
> actual
> reboot is.
>

Maybe... leaving swap on a mirrored disk will give a rebuild of the mirror  
on boot if swap is not swapped off.