From owner-svn-src-head@FreeBSD.ORG  Tue Nov 25 19:20:22 2008
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 94A4B1065675;
	Tue, 25 Nov 2008 19:20:22 +0000 (UTC) (envelope-from rink@rink.nu)
Received: from mx1.rink.nu (gloom.rink.nu [213.34.49.2])
	by mx1.freebsd.org (Postfix) with ESMTP id 522A38FC13;
	Tue, 25 Nov 2008 19:20:22 +0000 (UTC) (envelope-from rink@rink.nu)
Received: from localhost (localhost [127.0.0.1])
	by mx1.rink.nu (Postfix) with ESMTP id C85B56D42B;
	Tue, 25 Nov 2008 20:20:51 +0100 (CET)
X-Virus-Scanned: amavisd-new at rink.nu
Received: from mx1.rink.nu ([213.34.49.2])
	by localhost (gloom.rink.nu [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id 17B-a0havQh6; Tue, 25 Nov 2008 20:20:48 +0100 (CET)
Received: by mx1.rink.nu (Postfix, from userid 1000)
	id C29366D423; Tue, 25 Nov 2008 20:20:48 +0100 (CET)
Date: Tue, 25 Nov 2008 20:20:48 +0100
From: Rink Springer <rink@FreeBSD.org>
To: Ulf Lilleengen <lulf@FreeBSD.org>
Message-ID: <20081125192048.GA12700@rink.nu>
References: <200811251913.mAPJDwrD032237@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200811251913.mAPJDwrD032237@svn.freebsd.org>
User-Agent: Mutt/1.5.18 (2008-05-17)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r185309 - head/sys/geom/vinum
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 25 Nov 2008 19:20:22 -0000

On Tue, Nov 25, 2008 at 07:13:58PM +0000, Ulf Lilleengen wrote:
> Author: lulf
> Date: Tue Nov 25 19:13:58 2008
> New Revision: 185309
> URL: http://svn.freebsd.org/changeset/base/185309
> 
> Log:
>   - Fix a potential NULL pointer reference. Note that this cannot happen in
>     practice, but it is a good programming practice nontheless and it allows the
>     kernel to not depend on userland correctness.

If it can't happen in practice, why not just ASSERT on them? This would
be useful for debugging, and it basically tells whoever reads the code
about the scenario's you are dealing with...

-- 
Rink P.W. Springer                                - http://rink.nu
"Anyway boys, this is America. Just because you get more votes doesn't
 mean you win." - Fox Mulder