From owner-freebsd-current@freebsd.org Sun Nov 15 07:48:01 2015 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EEB98A2FAC8; Sun, 15 Nov 2015 07:48:01 +0000 (UTC) (envelope-from freebsd.contact@marino.st) Received: from shepard.synsport.net (mail.synsport.com [208.69.230.148]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 6482413C6; Sun, 15 Nov 2015 07:48:01 +0000 (UTC) (envelope-from freebsd.contact@marino.st) Received: from [192.168.1.22] (210.Red-81-38-187.dynamicIP.rima-tde.net [81.38.187.210]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by shepard.synsport.net (Postfix) with ESMTP id 42E0243BA5; Sun, 15 Nov 2015 01:47:59 -0600 (CST) Subject: Re: Need help fixing failing locale tests To: NGie Cooper References: <69242BD8-9010-47F0-9706-BE206376ECEA@gmail.com> <289892B6-EACE-4BDA-B838-D3DC750319DE@gmail.com> <56482FA9.2010803@marino.st> <02FA2ED1-42BF-4BF2-879D-5463A119C000@gmail.com> Cc: Craig Rodrigues , Baptiste Daroussin , freebsd-current Current , "freebsd-testing@freebsd.org" Reply-To: marino@freebsd.org From: John Marino X-Enigmail-Draft-Status: N1110 Message-ID: <564838AD.2000402@marino.st> Date: Sun, 15 Nov 2015 08:47:57 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.0.1 MIME-Version: 1.0 In-Reply-To: <02FA2ED1-42BF-4BF2-879D-5463A119C000@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Mailman-Approved-At: Sun, 15 Nov 2015 12:17:47 +0000 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Nov 2015 07:48:02 -0000 On 11/15/2015 8:24 AM, NGie Cooper wrote: >> On Nov 14, 2015, at 23:09, John Marino wrote: >> Bapt liked DF approach well enough that he adopted it. Even Edwin was >> first in desiring to clean up locales. The major update was a perfect time. >> >> Bottom line: >> The testsuite needs to be updated. >> e.g. use de_DE.ISO8859-15 intead of de_DE.ISO8859-1 >> For latin, replace with US-ASCII equivalent. > > I wish this had been clearly communicated here: https://svnweb.freebsd.org/changeset/base/290494 … instead, there are some POLA violations: > 1. No RelNotes. > 2. No summary of locales that have been removed. > 3. No UPDATING entry for people to migrate from a locale to another. > 4. Deprecated locales (as you described it above) are still present on my system after running `make delete-old` (assuming I have my acronyms right, for example, ca_ES, it_CH, etc should be -1, not -15 based on your claim above). > I will update the testcases to use locales if possible, but more work needs to be done finishing off this project and documenting for end-users what has changed. With 4.) they have been removed from FreeBSD when "Make upgrade" is run after rebuilding. Does FreeBSD have a cleanup like that, and did you run it? If not, then maybe that needs to be updated. with 3.) That's a bit like saying changing the color of shoe laces needs instructions for people to learn how to adjust. Run "locale -a" to see what's available on the system. This has always been true. Attempting to switch to a locale that doesn't exist results in staying in "C" locale, which is quite obvious. with 2.) Could be combined with 1.) but in any case, there really shouldn't be POLA on anything that has no standard. Should you announce every time you add a locale too, in release notes? Really "locale -a" should tell the whole story. 1.) A paragraph on removed locales is fine. Those removed have been removed because they are a) likely unused and b) if used, they are used by mistake. in this case you hit c) where the testsuite probably chose the "wrong" locale in the first place. Note that GCC did this too with their libstdc++ testsuite and that was fixed this weekend (a huge patch to GCC 6 upstream). John