Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 4 Dec 2018 03:18:43 +0300
From:      Yuri Pankov <yuripv@FreeBSD.org>
To:        Oliver Pinter <oliver.pinter@hardenedbsd.org>
Cc:        "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>
Subject:   Re: svn commit: r341446 - head/release/amd64
Message-ID:  <7fd4cc67-52df-56e1-faa9-281d4ddf57e2@FreeBSD.org>
In-Reply-To: <CAPQ4ffsc8ESKB27H0L81cUMvw==pGGmRZ5LyfHOZD-C=j53-jA@mail.gmail.com>
References:  <201812032231.wB3MVvaD060931@repo.freebsd.org> <CAPQ4ffsc8ESKB27H0L81cUMvw==pGGmRZ5LyfHOZD-C=j53-jA@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--TxhaTWPRQJ2ksX0DpfHg7UT0rY26ln9TK
Content-Type: multipart/mixed; boundary="JBii87QMc7OvQB40DXOa5N5lnpm8VfgSC";
 protected-headers="v1"
From: Yuri Pankov <yuripv@FreeBSD.org>
To: Oliver Pinter <oliver.pinter@hardenedbsd.org>
Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>,
 "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>,
 "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>
Message-ID: <7fd4cc67-52df-56e1-faa9-281d4ddf57e2@FreeBSD.org>
Subject: Re: svn commit: r341446 - head/release/amd64
References: <201812032231.wB3MVvaD060931@repo.freebsd.org>
 <CAPQ4ffsc8ESKB27H0L81cUMvw==pGGmRZ5LyfHOZD-C=j53-jA@mail.gmail.com>
In-Reply-To: <CAPQ4ffsc8ESKB27H0L81cUMvw==pGGmRZ5LyfHOZD-C=j53-jA@mail.gmail.com>

--JBii87QMc7OvQB40DXOa5N5lnpm8VfgSC
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable

Oliver Pinter wrote:
>=20
>=20
> On Monday, December 3, 2018, Yuri Pankov <yuripv@freebsd.org
> <mailto:yuripv@freebsd.org>> wrote:
>=20
>     Author: yuripv
>     Date: Mon Dec=C2=A0 3 22:31:57 2018
>     New Revision: 341446
>     URL: https://svnweb.freebsd.org/changeset/base/341446
>     <https://svnweb.freebsd.org/changeset/base/341446>;
>=20
>     Log:
>     =C2=A0 mkisoimages.sh: don't use -p flag when copying loader.efi to=
 msdosfs.
>=20
>     =C2=A0 This fixes 'cdrom' target in the case when world was built b=
y user,
>     =C2=A0 and not root.
>=20
>     =C2=A0 Reviewed by:=C2=A0 imp
>     =C2=A0 Differential revision:=C2=A0 =C2=A0 =C2=A0 =C2=A0 https://re=
views.freebsd.org/D18414
>     <https://reviews.freebsd.org/D18414>;
>=20
>=20
> This was a known issue
> :=C2=A0https://lists.freebsd.org/pipermail/svn-src-head/2018-November/1=
19689.html

Sorry, I missed that.

Looking at the HBSD change, does chmod step have any significance?

>     Modified:
>     =C2=A0 head/release/amd64/mkisoimages.sh
>=20
>     Modified: head/release/amd64/mkisoimages.sh
>     =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D
>     --- head/release/amd64/mkisoimages.sh=C2=A0 =C2=A0Mon Dec=C2=A0 3 2=
2:09:23 2018=C2=A0 =C2=A0
>     =C2=A0 =C2=A0 (r341445)
>     +++ head/release/amd64/mkisoimages.sh=C2=A0 =C2=A0Mon Dec=C2=A0 3 2=
2:31:57 2018=C2=A0 =C2=A0
>     =C2=A0 =C2=A0 (r341446)
>     @@ -49,7 +49,7 @@ if [ "$1" =3D "-b" ]; then
>     =C2=A0 =C2=A0 =C2=A0 =C2=A0 mkdir efi
>     =C2=A0 =C2=A0 =C2=A0 =C2=A0 mount -t msdosfs /dev/$device efi
>     =C2=A0 =C2=A0 =C2=A0 =C2=A0 mkdir -p efi/efi/boot
>     -=C2=A0 =C2=A0 =C2=A0 =C2=A0cp -p "$BASEBITSDIR/boot/loader.efi" ef=
i/efi/boot/bootx64.efi
>     +=C2=A0 =C2=A0 =C2=A0 =C2=A0cp "$BASEBITSDIR/boot/loader.efi" efi/e=
fi/boot/bootx64.efi
>     =C2=A0 =C2=A0 =C2=A0 =C2=A0 umount efi
>     =C2=A0 =C2=A0 =C2=A0 =C2=A0 rmdir efi
>     =C2=A0 =C2=A0 =C2=A0 =C2=A0 mdconfig -d -u $device
>     _______________________________________________
>     svn-src-head@freebsd.org <mailto:svn-src-head@freebsd.org>=C2=A0mai=
ling list
>     https://lists.freebsd.org/mailman/listinfo/svn-src-head
>     <https://lists.freebsd.org/mailman/listinfo/svn-src-head>;
>     To unsubscribe, send any mail to
>     "svn-src-head-unsubscribe@freebsd.org
>     <mailto:svn-src-head-unsubscribe@freebsd.org>"
>=20



--JBii87QMc7OvQB40DXOa5N5lnpm8VfgSC--

--TxhaTWPRQJ2ksX0DpfHg7UT0rY26ln9TK
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEE+Gq3PsPeLT4tL/9wk4vgf7Eq4WwFAlwFx+MACgkQk4vgf7Eq
4WzmPwgAuLgp2QNmYXLc+o6UPfKpwr/rTN+DWjmSclG9QIlMHcxXcIllgzHNV7qw
v3cA/djw55rSxXcQy+YMiJIrC+Y5+6+pazruihkjv0dJkToeVJyQwHL+MFsTubWA
OKIKXfaFWsX9Lr68yWT1UwkiUN4Y/dxjnTZhPLgazu7YkVZqUTCIhZH4ZIJXTIR7
qyd5wKyM/Oky8UTyO40+Ow00kKTmkoJL4q9kS06XYe3tiYnLhPfYzBdbbHOccb9d
nzDbnDSfVXuU02ggccHSUm5kTIXbV2ROj4bdfmW+NgZmdr4gcvGjpoVvi31M3t/U
0pIGx8hrI3hxfBAVIHiW64LX1Km6VA==
=VV2T
-----END PGP SIGNATURE-----

--TxhaTWPRQJ2ksX0DpfHg7UT0rY26ln9TK--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7fd4cc67-52df-56e1-faa9-281d4ddf57e2>