From owner-svn-src-head@freebsd.org Tue Nov 6 00:14:23 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 14FB51110AE0; Tue, 6 Nov 2018 00:14:23 +0000 (UTC) (envelope-from arichardson.kde@gmail.com) Received: from mail-yb1-f175.google.com (mail-yb1-f175.google.com [209.85.219.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7E1557CD24; Tue, 6 Nov 2018 00:14:22 +0000 (UTC) (envelope-from arichardson.kde@gmail.com) Received: by mail-yb1-f175.google.com with SMTP id t13-v6so4610837ybb.8; Mon, 05 Nov 2018 16:14:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZZRVyheQ3qWQB7tIOkYAJGVLmZLcAVR6Urv7ajGBCXs=; b=BAX7auw2kKn0ArWvA4rulpYOn3S44/4hJT9vIv8/qlO3nRscVdkIquQ5gnE4rEnq/w Qn2AKunXhE8ul/B9D8N7PtntuhEybHYsyUZvJA7isQhfrtA6L/g4qwqCKejYQsD2PaQ7 yhMGwUi4054N8D08oDEpTDShCouWpIDwodQinq4h/zYix4qPBXrQoxq7zIFHke+xYwCk ZQuD9vWWtoxJPfE8VfsywErj0lYL5RlhRXg25dI7lywyN07pYIhVkGSqMPTqU4jGJHa+ HCviuYH6ElU970/CJcfzrLqPfZuOS1dztu2MgMVR6o868ekhYGfsVTaiT2/pSSc4gBm4 DiUQ== X-Gm-Message-State: AGRZ1gIVdo33kvhTJ8PgOU38nolE/1EW42ZtirPR4J+TbnqiLcTqvf2q 9/C9yx+UxzIo1g4AACe7ScYCdssS8CfzgA== X-Google-Smtp-Source: AJdET5eS0PwnBJ2Z1IL+aCiZO+dPXo6kVsJocvH31jKk34ZlMKWO+PL9YneWhsV8yRiFPokIL2krTg== X-Received: by 2002:a25:bcc2:: with SMTP id l2-v6mr22996076ybm.448.1541462946577; Mon, 05 Nov 2018 16:09:06 -0800 (PST) Received: from mail-yw1-f45.google.com (mail-yw1-f45.google.com. [209.85.161.45]) by smtp.gmail.com with ESMTPSA id m68-v6sm11877055ywf.95.2018.11.05.16.09.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 05 Nov 2018 16:09:06 -0800 (PST) Received: by mail-yw1-f45.google.com with SMTP id j75-v6so4440831ywj.10; Mon, 05 Nov 2018 16:09:05 -0800 (PST) X-Received: by 2002:a81:ae1a:: with SMTP id m26-v6mr24163975ywh.14.1541462945648; Mon, 05 Nov 2018 16:09:05 -0800 (PST) MIME-Version: 1.0 References: <201811051951.wA5JpB5q088141@repo.freebsd.org> <6aa3fcb9-2199-4d80-a006-f72c59f499c3@FreeBSD.org> In-Reply-To: <6aa3fcb9-2199-4d80-a006-f72c59f499c3@FreeBSD.org> From: Alexander Richardson Date: Tue, 6 Nov 2018 00:08:53 +0000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r340157 - in head: . tools/build tools/tools/nanobsd/embedded To: Bryan Drewery Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org X-Rspamd-Queue-Id: 7E1557CD24 X-Spamd-Result: default: False [-3.99 / 200.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; RCVD_TLS_LAST(0.00)[]; DMARC_NA(0.00)[freebsd.org]; TO_DN_SOME(0.00)[]; NEURAL_HAM_LONG(-1.00)[-0.999,0]; RCVD_COUNT_THREE(0.00)[4]; IP_SCORE(-0.99)[ipnet: 209.85.128.0/17(-3.57), asn: 15169(-1.33), country: US(-0.07)]; MX_GOOD(-0.01)[cached: alt3.gmail-smtp-in.l.google.com]; NEURAL_HAM_SHORT(-0.99)[-0.993,0]; RCVD_IN_DNSWL_NONE(0.00)[175.219.85.209.list.dnswl.org : 127.0.5.0]; FORGED_SENDER(0.30)[arichardson@freebsd.org,arichardsonkde@gmail.com]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; TAGGED_FROM(0.00)[]; FROM_NEQ_ENVFROM(0.00)[arichardson@freebsd.org,arichardsonkde@gmail.com] X-Rspamd-Server: mx1.freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Nov 2018 00:14:23 -0000 On Mon, 5 Nov 2018, 23:32 Bryan Drewery On 11/5/2018 11:51 AM, Alex Richardson wrote: > > Author: arichardson > > Date: Mon Nov 5 19:51:10 2018 > > New Revision: 340157 > > URL: https://svnweb.freebsd.org/changeset/base/340157 > > > > Log: > > Allow building world without inheriting $PATH > > > > This change has a summary that doesn't seem to match its change (to > build host tools for cross-os builds). > Does $PATH go into the build still or not? SYSTEM_COMPILER relies on > $PATH inheriting into the build. Bootstrapping of host tools does not change unless BOOTSTRAP_ALL_TOOLS is set on the make command line (this will be the default for cross-os builds but that still requires more changes). This patch only ensures that the required tools are symlinked into worldtmp. $PATH should only be inherited for the bootstrap-tools phase. I thought I had tested all variations of universe builds but it looks like I forgot to test on a SYSTEM_COMPILER machine so didn't notice it is needed there. This should be fixed in r340167. $PATH will now be inherited when using the system compiler or linker but otherwise the strict path will be used. In case I missed more cases: the new strict path behaviour can be disabled by setting BUILD_WITH_STRICT_TMPPATH=0. Sorry about any breakage. Alex