From owner-freebsd-stable@FreeBSD.ORG Wed Jan 23 14:49:44 2008 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5DDDF16A46C for ; Wed, 23 Jan 2008 14:49:44 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.freebsd.org (Postfix) with ESMTP id 43C4E13C468 for ; Wed, 23 Jan 2008 14:49:44 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from zion.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by elvis.mu.org (Postfix) with ESMTP id 4B6311A4D89; Wed, 23 Jan 2008 06:45:52 -0800 (PST) From: John Baldwin To: freebsd-stable@freebsd.org Date: Wed, 23 Jan 2008 09:24:37 -0500 User-Agent: KMail/1.9.7 References: <47949811.1080505@raad.tartu.ee> <479501BE.4040309@FreeBSD.org> <99B0737B-9876-4D86-A9DC-FB5FAD21CB21@kcilink.com> In-Reply-To: <99B0737B-9876-4D86-A9DC-FB5FAD21CB21@kcilink.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200801230924.37310.jhb@freebsd.org> Cc: Vivek Khera Subject: Re: NO_ knobs in /etc/make.conf X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jan 2008 14:49:44 -0000 On Tuesday 22 January 2008 12:36:47 pm Vivek Khera wrote: > > On Jan 21, 2008, at 3:34 PM, Doug Barton wrote: > > > There is a cross-reference to src.conf(5) at the end of > > make.conf(5), but IMO the connection needs to be made more explicit. > > Anyone want to take that on? This should also go in the release > > notes if it's not already. > > So do I need to move my settings from make.conf to src.conf, or can I > just leave it as-is and not worry about it. Reading the make.conf man > page implies it will just continue to work without change. You can just s/NO_/WITHOUT_/g on your /etc/make.conf and leave them there. > What was broken that required this to be "fixed"? Inconsistent use of what NO_FOO= meant. Some places only checked if it was set, other places required it to be set to "yes", so NO_FOO=no might disable FOO or it might not. The WITHOUT_* / WITH_* scheme was chosen to be compatible with how ports works. If WITHOUT_FOO is defined then FOO is disabled. If WITH_FOO is defined, then FOO is enabled. The WITH_FOO/WITHOUT_FOO variables end up setting an internal MK_FOO variable to "yes" or "no" and the actual Makefiles for FOO compare MK_FOO to "yes" to see if they should build. -- John Baldwin