From owner-cvs-all Mon Feb 3 13:53:12 2003 Delivered-To: cvs-all@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 931) id 7856E37B401; Mon, 3 Feb 2003 13:53:11 -0800 (PST) Date: Mon, 3 Feb 2003 13:53:10 -0800 From: Juli Mallett To: Gordon Tetlow Cc: Dag-Erling Smorgrav , phk@FreeBSD.org, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/geom geom_vol_ffs.c Message-ID: <20030203135310.B44770@FreeBSD.org> References: <11633.1044300113@critter.freebsd.dk> <20030203201026.GD98559@roark.gnf.org> <20030203134932.A44770@FreeBSD.org> <20030203215045.GJ98559@roark.gnf.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: <20030203215045.GJ98559@roark.gnf.org>; from gordont@gnf.org on Mon, Feb 03, 2003 at 01:50:45PM -0800 Organisation: The FreeBSD Project X-Alternate-Addresses: , , , , X-Towel: Yes X-LiveJournal: flata, jmallett X-Negacore: Yes Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG * De: Gordon Tetlow [ Data: 2003-02-03 ] [ Subjecte: Re: cvs commit: src/sys/geom geom_vol_ffs.c ] > On Mon, Feb 03, 2003 at 01:49:32PM -0800, Juli Mallett wrote: > > * De: Gordon Tetlow [ Data: 2003-02-03 ] > > [ Subjecte: Re: cvs commit: src/sys/geom geom_vol_ffs.c ] > > > > - Although tunefs(8) won't let you set a volume label containing > > > > anything but alphanumerics (IMHO, it should accept underscores as > > > > well), there's nothing in g_vol_ffs_taste() that checks for invalid > > > > characters in the label. What happens if I manually edit the > > > > superblock and put a / in there? (imagine inserting a borrowed Zip > > > > disk and boom...) > > > > > > I've got a commit in my tree that adds a comment about this. It's on > > > my TODO list. I was thinking of adding . as a valid character as well > > > (but disallowing leading periods for security reasons). > > > > Security reasons? What's wrong with things like ls hiding certain > > volumes in /dev/vol/ if they aren't using -a or similar? > > I was thinking more along the lines of .. "File exists" -- Juli Mallett AIM: BSDFlata -- IRC: juli on EFnet OpenDarwin, Mono, FreeBSD Developer ircd-hybrid Developer, EFnet addict FreeBSD on MIPS-Anything on FreeBSD To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message