From owner-svn-src-head@freebsd.org Tue Apr 4 18:56:33 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D3044D2D49B; Tue, 4 Apr 2017 18:56:33 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from tensor.andric.com (tensor.andric.com [IPv6:2001:470:7a58:1::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "tensor.andric.com", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9D52AB6A; Tue, 4 Apr 2017 18:56:33 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from [IPv6:2001:470:7a58::988f:bd7f:a95:844] (unknown [IPv6:2001:470:7a58:0:988f:bd7f:a95:844]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id 7C78836F1D; Tue, 4 Apr 2017 20:56:31 +0200 (CEST) From: Dimitry Andric Message-Id: Content-Type: multipart/signed; boundary="Apple-Mail=_DE1F8A13-1FBF-4A2F-ACF0-7A7803834193"; protocol="application/pgp-signature"; micalg=pgp-sha1 Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: Re: svn commit: r316492 - in head/usr.bin/grep: . regex Date: Tue, 4 Apr 2017 20:56:23 +0200 In-Reply-To: <4D675D2F-7D6F-4AF2-AE10-5DF19D4158D0@gmail.com> Cc: Conrad Meyer , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org To: "Ngie Cooper (yaneurabeya)" References: <201704041608.v34G8qSo055328@repo.freebsd.org> <4D675D2F-7D6F-4AF2-AE10-5DF19D4158D0@gmail.com> X-Mailer: Apple Mail (2.3273) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Apr 2017 18:56:33 -0000 --Apple-Mail=_DE1F8A13-1FBF-4A2F-ACF0-7A7803834193 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 On 4 Apr 2017, at 19:14, Ngie Cooper (yaneurabeya) = wrote: >=20 >> On Apr 4, 2017, at 09:08, Conrad Meyer wrote: >>=20 >> Author: cem >> Date: Tue Apr 4 16:08:51 2017 >> New Revision: 316492 >> URL: https://svnweb.freebsd.org/changeset/base/316492 >>=20 >> Log: >> bsdgrep(1): Rip out "xmalloc" bits >>=20 >> xmalloc was a debug malloc implementation, but the = x{malloc,calloc,free} >> functions default to calling the malloc(3) equivalents. >>=20 >> Instead of relying on this malloc shim, we can devise better ways to = debug >> malloc issues that aren't misleading upon initial inspection. (I.e., = using >> jemalloc's various built-in debugging capabilities.) >>=20 >> Submitted by: Kyle Evans >> Reviewed by: emaste, cem >> Differential Revision: https://reviews.freebsd.org/D10269 >>=20 >> Deleted: >> head/usr.bin/grep/regex/xmalloc.c >> head/usr.bin/grep/regex/xmalloc.h >> Modified: >> head/usr.bin/grep/Makefile >> head/usr.bin/grep/regex/fastmatch.c >> head/usr.bin/grep/regex/tre-compile.c >> head/usr.bin/grep/regex/tre-fastmatch.c >=20 > Where did xmalloc.c originate from? GNU. Almost all software from the GNU project relies on malloc wrappers which abort the program on allocation failures. > I can=E2=80=99t find any references to it in OpenBSD=E2=80=99s grep = implementation (I=E2=80=99m pretty sure this copy of grep started = there). Not sure, they must have disliked the GNUisms too, probably. :) -Dimitry --Apple-Mail=_DE1F8A13-1FBF-4A2F-ACF0-7A7803834193 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.30 iEYEARECAAYFAljj7F8ACgkQsF6jCi4glqOefwCff5XvCW749M/S42MNQ8lU9ILU J2MAoKKi91o9dC2iWqrssVD4K+fkldK+ =7hUw -----END PGP SIGNATURE----- --Apple-Mail=_DE1F8A13-1FBF-4A2F-ACF0-7A7803834193--