From nobody Sat Sep 28 19:36:12 2024 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XGHdt13ycz5XlSc for ; Sat, 28 Sep 2024 19:36:50 +0000 (UTC) (envelope-from sunpoet@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XGHdt08DZz54dl for ; Sat, 28 Sep 2024 19:36:50 +0000 (UTC) (envelope-from sunpoet@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1727552210; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ViXkbbNcDmHiC/ouW+NV2EkXMixvpXTDZnRwg5yAa0k=; b=xCUMlwmAgYT29T7+7gPYyOhexVxVv7crRck3SN+kP8t/Byvi924PFGFYu0foOWgTUIIC5B KfvJAkI9TroOADVd5LxAL5LoVtH1VWrvryy7ZssxZgBtDptomcLunXaDdM349hIupG1kaI uaKgjxKXLUD258IDOrj/Tv/NH4B9k3vxs8Sv2+vVjBntGEXbe1usonnZ7H2Dqjuce6qajx X5bhpzrJqJkDZqWfFWwTBg7i6/+HiXbffr5cygsCZp4hdjWZ4Mi94dvjto28gz5WCnXnRA plaQwv0GE0dZTKjtYJZdwQTEfD1KrtsoNRlx9Ml1r0NO4+8D/EA5kZhiibzi6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1727552210; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ViXkbbNcDmHiC/ouW+NV2EkXMixvpXTDZnRwg5yAa0k=; b=JSsgA9Lt7FSN7VkR1eBiHPEGDi7zYwnALMezVcor/FuMlTN9uWoMsp2y1I9dulCScDvS85 8JPljJY5PQ39i8ofCChHenW4f9JtLxDKsybbRQ7Z5taSCXmGGJCqBv83+EpyruV516KfDU BuI6b5eBte1ZlJwkf6rUWibnPVprKx0Kl5zZ1WSzls4Rbmb/1YCwkaQAnKURLlisbUYkd/ +OTTmCvo4b2MtpTXp+/egSRSAmMhvLJavPVnlv0MGq+YgPBw4ycDUylLLWuod1BmTgDMuv 90m5qaCfL5kttCWfrnuwB5AScS5S/croR6AjZudYUP7E5wN5puethm/lkT3B4g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1727552210; a=rsa-sha256; cv=none; b=AWuuh+CX0YYOnul+HAxURfC5GexRpjBvVwooSv5ZX4ZCNf/dp4fex/y45uSJ1RToJqu+tY 9Jpw6D4b8+ygz0/k3j1HXV8AMq9E39CifT/4FJx7uzjv3hIdZJdzXfVgUy86MzcylY51pK qOS9m5XdKIPEGdo8Pzt18TNH5m/WC40lBphp0tU5KqzoahAbORw0rPO9Y9xWUgbqKAC0C5 2jhzmRw1NUkAu3UHfZnzZsAMe9Ehj1Thf6fg19Tc+FDVDVvk9GZvDsRaBDyekn63s2KzE5 omAp3XUaOwOgcHwkzQE6Q2kO8Va+ydR59L5yDJS7CiWu4dZG1lS4jxfUH3/pvQ== Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com [209.85.208.49]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) (Authenticated sender: sunpoet) by smtp.freebsd.org (Postfix) with ESMTPSA id 4XGHds6k0DzQJY for ; Sat, 28 Sep 2024 19:36:49 +0000 (UTC) (envelope-from sunpoet@freebsd.org) Received: by mail-ed1-f49.google.com with SMTP id 4fb4d7f45d1cf-5c88c9e45c2so718094a12.0 for ; Sat, 28 Sep 2024 12:36:49 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCXlEs3A0qiJIa2LAXhO9o0KcOlAzcuu5mCavS7tduaYQGesFnxQhWgH/gMv8mXOb7YBagWGmqy6vT84JIBdP7715hENRxg=@freebsd.org X-Gm-Message-State: AOJu0Yz3YmcMJSn+tzwkEEsUi0BD4BYlOjnhylU9kafxdd8NjTjHVqIQ BI6dnp48AYaxY5KHC6EAGW6IUdst8Gi9H64s19wjAWOKx+fm/Sl0MAgjc4/w/7UBk5YdrAzya73 +eIqN4/wMBNbfZjnteEpLfhq2G054AvIqBinmJA== X-Google-Smtp-Source: AGHT+IGA9ha6nMrhBlaASoY+wWlzzyZ/GxkKz03WvoIQ1oJyezViuyenqd2foEAfw0EgQX70ETB+0HBqJ2gcfvW3qj8= X-Received: by 2002:a05:6402:35c1:b0:5c8:8c16:3971 with SMTP id 4fb4d7f45d1cf-5c88c163cc1mr1827152a12.16.1727552208734; Sat, 28 Sep 2024 12:36:48 -0700 (PDT) List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-all@freebsd.org Sender: owner-dev-commits-ports-all@FreeBSD.org MIME-Version: 1.0 References: <202409180619.48I6J0G7032519@gitrepo.freebsd.org> In-Reply-To: From: Po-Chuan Hsieh Date: Sun, 29 Sep 2024 03:36:12 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: c41e1ace8e98 - main - ftp/curl: Add LIBUV option To: Adam Weinberger Cc: ports-committers , dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Content-Type: multipart/alternative; boundary="000000000000bbb2b5062333175f" --000000000000bbb2b5062333175f Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Sep 19, 2024 at 11:10=E2=80=AFAM Adam Weinberger = wrote: > On Wed, Sep 18, 2024 at 2:19=E2=80=AFAM Po-Chuan Hsieh > wrote: > >> The branch main has been updated by sunpoet: >> >> URL: >> https://cgit.FreeBSD.org/ports/commit/?id=3Dc41e1ace8e986493e3fc0b22fa04= 61aa098182e0 >> >> commit c41e1ace8e986493e3fc0b22fa0461aa098182e0 >> Author: Po-Chuan Hsieh >> AuthorDate: 2024-09-18 05:55:59 +0000 >> Commit: Po-Chuan Hsieh >> CommitDate: 2024-09-18 06:13:08 +0000 >> >> ftp/curl: Add LIBUV option >> --- >> ftp/curl/Makefile | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/ftp/curl/Makefile b/ftp/curl/Makefile >> index 0eebfd2224dd..8bacab43595b 100644 >> --- a/ftp/curl/Makefile >> +++ b/ftp/curl/Makefile >> @@ -41,7 +41,7 @@ CPE_VENDOR=3D haxx >> >> SHEBANG_FILES=3D */*.pl >> >> -OPTIONS_DEFINE=3D ALTSVC BROTLI COOKIES CURL_DEBUG DEBUG DOCS >> EXAMPLES IDN IPV6 NTLM PROXY PSL STATIC TLS_SRP ZSTD >> +OPTIONS_DEFINE=3D ALTSVC BROTLI COOKIES CURL_DEBUG DEBUG DOCS >> EXAMPLES IDN IPV6 LIBUV NTLM PROXY PSL STATIC TLS_SRP ZSTD >> OPTIONS_GROUP=3D PROTOCOL >> OPTIONS_RADIO=3D SSL >> OPTIONS_SINGLE=3D GSSAPI RESOLV >> @@ -123,6 +123,8 @@ LIBSSH_CONFIGURE_WITH=3D libssh >> LIBSSH_LIB_DEPENDS=3D libssh.so:security/libssh >> LIBSSH2_CONFIGURE_WITH=3D libssh2 >> LIBSSH2_LIB_DEPENDS=3D libssh2.so:security/libssh2 >> +LIBUV_CONFIGURE_WITH=3D libuv >> +LIBUV_LIB_DEPENDS=3D libuv.so:devel/libuv >> MQTT_CONFIGURE_ENABLE=3D mqtt >> NTLM_CONFIGURE_ENABLE=3D ntlm >> OPENSSL_CONFIGURE_ON=3D --with-ca-fallback >> > > Hi, Po-Chuan! > > There's no description for this new LIBUV option, so I was unclear what > libuv did for Curl. In upstream's configure.ac, it has this: > > dnl *********************************************************************= * > dnl libuv is only ever used for debug purposes > dnl *********************************************************************= * > > ... > > if test X"$want_libuv" !=3D Xno; then > if test x$want_debug !=3D xyes; then > AC_MSG_ERROR([Using libuv without debug support enabled is useless]) > fi > > So, the LIBUV option *must* be used with the DEBUG option. If linking > against libuv is going to be important for end-users, we probably want > LIBUV_IMPLIES=3DDEBUG. > > # Adam > Hello Adam, Thanks for taking care of this option. I have added the missing LIBUV_DESC earlier. It is not useful for normal users since it is for testing. Therefore I did not enable it by default. I'll add "LIBUV_IMPLIES=3DDEBUG" later. Thanks. Best regards, sunpoet --000000000000bbb2b5062333175f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Thu= , Sep 19, 2024 at 11:10=E2=80=AFAM Adam Weinberger <adamw@adamw.org>= wrote:
On Wed, Sep 18, 2024 at 2:19=E2=80=AFAM Po-Chuan Hsie= h <sunpoet@freebsd.org> wrote:
The branch main has = been updated by sunpoet:

URL: = https://cgit.FreeBSD.org/ports/commit/?id=3Dc41e1ace8e986493e3fc0b22fa0461a= a098182e0

commit c41e1ace8e986493e3fc0b22fa0461aa098182e0
Author:=C2=A0 =C2=A0 =C2=A0Po-Chuan Hsieh <sunpoet@FreeBSD.org>
AuthorDate: 2024-09-18 05:55:59 +0000
Commit:=C2=A0 =C2=A0 =C2=A0Po-Chuan Hsieh <sunpoet@FreeBSD.org>
CommitDate: 2024-09-18 06:13:08 +0000

=C2=A0 =C2=A0 ftp/curl: Add LIBUV option
---
=C2=A0ftp/curl/Makefile | 4 +++-
=C2=A01 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/ftp/curl/Makefile b/ftp/curl/Makefile
index 0eebfd2224dd..8bacab43595b 100644
--- a/ftp/curl/Makefile
+++ b/ftp/curl/Makefile
@@ -41,7 +41,7 @@ CPE_VENDOR=3D=C2=A0 =C2=A0haxx

=C2=A0SHEBANG_FILES=3D */*.pl

-OPTIONS_DEFINE=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 ALTSVC BROTLI COOKIES CURL_DE= BUG DEBUG DOCS EXAMPLES IDN IPV6 NTLM PROXY PSL STATIC TLS_SRP ZSTD
+OPTIONS_DEFINE=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 ALTSVC BROTLI COOKIES CURL_DE= BUG DEBUG DOCS EXAMPLES IDN IPV6 LIBUV NTLM PROXY PSL STATIC TLS_SRP ZSTD =C2=A0OPTIONS_GROUP=3D PROTOCOL
=C2=A0OPTIONS_RADIO=3D SSL
=C2=A0OPTIONS_SINGLE=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 GSSAPI RESOLV
@@ -123,6 +123,8 @@ LIBSSH_CONFIGURE_WITH=3D=C2=A0 =C2=A0 =C2=A0 libssh
=C2=A0LIBSSH_LIB_DEPENDS=3D=C2=A0 =C2=A0 libssh.so:security/libssh
=C2=A0LIBSSH2_CONFIGURE_WITH=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 libssh2
=C2=A0LIBSSH2_LIB_DEPENDS=3D=C2=A0 =C2=A0libssh2.so:security/libssh2
+LIBUV_CONFIGURE_WITH=3D=C2=A0 libuv
+LIBUV_LIB_DEPENDS=3D=C2=A0 =C2=A0 =C2=A0libuv.so:devel/libuv
=C2=A0MQTT_CONFIGURE_ENABLE=3D mqtt
=C2=A0NTLM_CONFIGURE_ENABLE=3D ntlm
=C2=A0OPENSSL_CONFIGURE_ON=3D=C2=A0 --with-ca-fallback

Hi, Po-Chuan!

There's no description = for this new LIBUV option, so I was unclear what libuv did for Curl. In ups= tream's configure.ac, it has this:

dnl ******= ****************************************************************
dnl lib= uv is only ever used for debug purposes
dnl ****************************= ******************************************

...

if= test X"$want_libuv" !=3D Xno; then
=C2=A0 if test x$want_debu= g !=3D xyes; then
=C2=A0 =C2=A0 AC_MSG_ERROR([Using libuv without debug = support enabled is useless])
=C2=A0 fi

So, t= he LIBUV option *must* be used with the DEBUG option. If linking against li= buv is going to be important for end-users, we probably want LIBUV_IMPLIES= =3DDEBUG.

# Adam
=

Hello Adam,

Thanks for taking = care of this option.
I have added the missing LIBUV_DESC earlier.=
It is not useful for normal users since it is for testing. T= herefore I did not enable it by default.
I'll add "LIBUV_IMPLIES=3DDEBUG" later.<= /span>
Thanks.

Best regards,
sunpoet
--000000000000bbb2b5062333175f--