From owner-freebsd-hackers Sat Jan 7 12:27:52 1995 Return-Path: hackers-owner Received: (from root@localhost) by freefall.cdrom.com (8.6.9/8.6.6) id MAA25182 for hackers-outgoing; Sat, 7 Jan 1995 12:27:52 -0800 Received: from estienne.cs.berkeley.edu (estienne.CS.Berkeley.EDU [128.32.42.147]) by freefall.cdrom.com (8.6.9/8.6.6) with ESMTP id MAA25176 for ; Sat, 7 Jan 1995 12:27:51 -0800 Received: (from gibbs@localhost) by estienne.cs.berkeley.edu (8.6.9/8.6.9) id NAA20491; Sat, 7 Jan 1995 13:00:18 -0800 From: "Justin T. Gibbs" Message-Id: <199501072100.NAA20491@estienne.cs.berkeley.edu> Subject: Re: Commit testing To: dufault@hda.com (Peter Dufault) Date: Sat, 7 Jan 1995 13:00:17 -0800 (PST) Cc: freebsd-hackers@freefall.cdrom.com In-Reply-To: <199501071726.MAA08014@hda.com> from "Peter Dufault" at Jan 7, 95 12:26:07 pm X-Mailer: ELM [version 2.4 PL24] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Length: 1751 Sender: hackers-owner@FreeBSD.org Precedence: bulk > > How do committers test things? I want to commit changes to > sys/scsi/* and sys/i386/isa/aha1542.c. (the diffs, if you want to > see them, are on freefall in pub:incoming/sutar7.gz) How do you I've been running sutar6 (plus the resolution of some conflicts with Rod's scsi changes) ever since it was released. I haven't noticed anything unusual. > handle the time between when you've thoroughly tested something > and you then check it into -current? By hoping and watching commit > logs? Well, I usually thoroughly test my code, and when I'm ready to commit it, SUP current and rebuild, do about an hour or so of testing again, and commit. Then I re-sup, merge conflicts, and retest to see if I've left anything out or botched the commit. For future commits, I plan on checking out a brand new copy of the kernel sources (I sup CVS) in this phase since otherwise its hard to tell if you left anything out of the commit. > > And does anyone review changes before they are commited, and > what is that process? I think it depends on what you're doing. In the case of the aic7770 driver, there are very few people that would be able to review my changes. I guess it is more of an ownership kind of thing, but it would be nice to have a real policy on this. > > Peter > > -- > Peter Dufault Real Time Machine Control and Simulation > HD Associates, Inc. Voice: 508 433 6936 > dufault@hda.com Fax: 508 433 5267 > -- Formerly hd@world.std.com. E-mail problems? Tell hdslip@iii.net > -- Justin T. Gibbs ============================================== TCS Instructional Group - Programmer/Analyst 1 Cory | Po | Danube | Volga | Parker | Torus ==============================================