From owner-svn-src-all@freebsd.org Sun Mar 3 20:56:45 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A5CF61519CD7 for ; Sun, 3 Mar 2019 20:56:45 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qt1-x844.google.com (mail-qt1-x844.google.com [IPv6:2607:f8b0:4864:20::844]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8899F6BD29 for ; Sun, 3 Mar 2019 20:56:44 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qt1-x844.google.com with SMTP id p48so3178733qtk.2 for ; Sun, 03 Mar 2019 12:56:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wMMpYwIeF+dwhUN+ek3t0+0gKJo4o2dXAEVTjZRzj/k=; b=D6/2/wV7ZkPTNkF7qb8pMjEr6AO9M1cOb9wRNxgAzeJTAJrWVl+D560jN2qjqesLkC 8JOHy6edP+aZoEqrGKWMJ1JvwNtlAWfBeGHQ+kjnBbkl/M1X6hHDKFFldJHNYP6pTWRX BQq+iRiVQWHoohyUqjInrmHXqVxZZ6aq9vW7CZRqGBj5gPM3ynBNWzRT+ofzny0bLSf9 BxU79cekBAQnlocZgkWdYqNTDssjUoBstVVE3/y3M8f7DRBOb7e6oeQzZ6+BaTG6lRvI yhvZjZoQpLtCqZnHfjc+I28jnMxGplofUqA7p6QwkamzO2DLBqJ9HAb9yQxn9SKd3MA1 Tg9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wMMpYwIeF+dwhUN+ek3t0+0gKJo4o2dXAEVTjZRzj/k=; b=t+SB71rT6giU7Ay7VP0pO8AX0rHuc2Rt8TRMBxepcYWNIsaZ4SOqmMFMqMpBOnjipc eA0JgPxW6sPjMQZuhnwRpa49hyUk0BX3EydXmucYbV1Z799ty4D59X+v25iksS2qhe7x 7qv6wBX3giupkH63jK6mBpvBXcWNMUgoAImh2FvCwahI+uM14zaW0xbUmyYU841pylrP k1e0RCY0Dt5hofNBcHXqpYodDCUr+EyaOyMNWtwmt5opeMtJjdf5WIVDUf+ceZSbs4Ox OV7t9ZRMGHOi7qXjZDyMGKEqG+f40gL5+CFeARhLOTxBRwd8IMd9r5ke1Mk4iDX3JCfK 7ROg== X-Gm-Message-State: APjAAAVd/qmLle7lzPgb2EMIgnpj9USLvHRLc3BW8SaFFFtL1R356Y3m crVsBhOk1f5aIMeQ8HTXFfONRxFm/d+mjJ3LJ4/A4w== X-Google-Smtp-Source: APXvYqx1gcFAwZnXVjwqnYW/HNGquupqqNVmSQiDXSOSCRxHC4ZOKabB9IYsnhbtwq1fLjH1VPlGhQs5FTWoPmS/D4E= X-Received: by 2002:ac8:3974:: with SMTP id t49mr12568487qtb.118.1551646603760; Sun, 03 Mar 2019 12:56:43 -0800 (PST) MIME-Version: 1.0 References: <201903011439.x21EdFlH055596@repo.freebsd.org> <20190302104909.GA25217@FreeBSD.org> <64CCD099-1916-4ACC-B1B6-3F22BDE55C7C@gmail.com> <06d7e6402ad6f673b15873a9d99c9382f21e64b9.camel@freebsd.org> In-Reply-To: <06d7e6402ad6f673b15873a9d99c9382f21e64b9.camel@freebsd.org> From: Warner Losh Date: Sun, 3 Mar 2019 13:56:32 -0700 Message-ID: Subject: Re: svn commit: r344701 - head/sbin/camcontrol To: Ian Lepore Cc: Garrett Cooper , Steven Hartland , Alexey Dokuchaev , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-Rspamd-Queue-Id: 8899F6BD29 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20150623.gappssmtp.com header.s=20150623 header.b=D6/2/wV7 X-Spamd-Result: default: False [-2.75 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.97)[-0.970,0]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com:s=20150623]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; NEURAL_HAM_LONG(-1.00)[-0.996,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-src-all@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; NEURAL_HAM_SHORT(-0.33)[-0.335,0]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; MX_GOOD(-0.01)[ALT1.aspmx.l.google.com,aspmx.l.google.com,ALT2.aspmx.l.google.com]; RCPT_COUNT_SEVEN(0.00)[7]; RCVD_IN_DNSWL_NONE(0.00)[4.4.8.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; R_SPF_NA(0.00)[]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; MIME_TRACE(0.00)[0:+,1:+]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; IP_SCORE(-0.44)[ip: (2.60), ipnet: 2607:f8b0::/32(-2.70), asn: 15169(-2.04), country: US(-0.07)]; FREEMAIL_CC(0.00)[gmail.com] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 Mar 2019 20:56:45 -0000 On Sun, Mar 3, 2019, 1:29 PM Ian Lepore wrote: > On Sun, 2019-03-03 at 12:20 -0800, Enji Cooper wrote: > > > On Mar 3, 2019, at 11:12, Steven Hartland > > > wrote: > > > > > > Not really much more to say that isn't explained by that and the > > > code. > > > > > > Sure I could have used a different sentence structure for the body > > > but it wouldn't add anything IMO, thoughts? > > > > Why the previous sector size was wrong isn=E2=80=99t clear from the > > commit message. Why switch from a sizeof to 0? > > Cheers! > > -Enji > > > > The commit message said it was "incorrect / unused". While a bit terse, > it does communicate that the old value was incorrect (by being there at > all) because the value is unused (so zero more clearly expresses that). > Correct. The standard also encourages that for future proofing the code. Though in this case this opcode is so old, there is almost zero chance it will change. Warner It's not completely a joke that most English-speaking software > engineers have English as a second language. :) > > -- Ian > > > >