From owner-freebsd-x11@FreeBSD.ORG Thu Feb 13 23:37:37 2014 Return-Path: Delivered-To: freebsd-x11@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 182E9D72 for ; Thu, 13 Feb 2014 23:37:37 +0000 (UTC) Received: from mail-qc0-x235.google.com (mail-qc0-x235.google.com [IPv6:2607:f8b0:400d:c01::235]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id C579F11D5 for ; Thu, 13 Feb 2014 23:37:36 +0000 (UTC) Received: by mail-qc0-f181.google.com with SMTP id e9so18841223qcy.40 for ; Thu, 13 Feb 2014 15:37:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=JVOuPOCldmcjWweVed8bJP+Sf7BQXAH7sc/evMCGG4Y=; b=c6+3vuTKeN0L34V13wcvrWWx27wX4jYG4OVXp9aVmkRU9bFy7sOONMi0JPtj02iNx1 +r9cqHeVbrFxEsi7ymmI8ssapxfs77BVuzpa+3N9Fqppd7bXyOcs8nqbCRqxBGfX5VJx 7GV6SCB6vt1WyObDS3zzgSM2Z0yYbT+FtPxDQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=JVOuPOCldmcjWweVed8bJP+Sf7BQXAH7sc/evMCGG4Y=; b=Zpzno2DTEi52bPGUTq8MCJFHdzc+bLSB51tzE4taz2KfcLuu+3Qupc2jAJW0wxmK0/ qO95O27R9pJcgaIu6QzQuMDphRq00ARIZxa98rf2/KxNdnXo1xWQ4Vc5hTaplu4kuEJ+ xUeM3F+VrPMpK6s/TfQGIDrvNmsHSVkbNma78xO//BOU1ZkaFXtggzsOqTfEcAWhoZol KSgF7DwFBUTYDoCpZyP2cZCi0HqpPSl442VRjciAzzy2aZzjOl3td+skL+vmRvYiVkuX JkzApUs0AiTMYZD6HpUNOcgKdLU3gdMlB2ZTwInX/9B92Fr96nzf/akzFRAv8Mcc3r9W KGXA== X-Gm-Message-State: ALoCoQlyt6+rXZ9Xw0vqpWx8R/Rs0I6uqfUZTE3f1C5+IM9IZjVYdW+q7T91iihD+yMn/goXgMqA X-Received: by 10.224.165.133 with SMTP id i5mr7525659qay.75.1392334655931; Thu, 13 Feb 2014 15:37:35 -0800 (PST) MIME-Version: 1.0 Received: by 10.96.175.169 with HTTP; Thu, 13 Feb 2014 15:37:05 -0800 (PST) In-Reply-To: <52FD55C3.4020406@freebsd.org> References: <52EFAAF8.20009@freebsd.org> <52FD55C3.4020406@freebsd.org> From: Eitan Adler Date: Thu, 13 Feb 2014 18:37:05 -0500 Message-ID: Subject: Re: [PATCH] replace isnumber() with isdigit() in X devd backend To: Robert Millan Content-Type: text/plain; charset=UTF-8 Cc: freebsd-x11@freebsd.org, Alex Kozlov X-BeenThere: freebsd-x11@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: X11 on FreeBSD -- maintaining and support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Feb 2014 23:37:37 -0000 On Thu, Feb 13, 2014 at 6:31 PM, Robert Millan wrote: > On 03/02/2014 14:43, Robert Millan wrote: >> >> isdigit() is more correct in this case (the input is not locale-dependant), >> and also more portable since it is provided on systems with Glibc (e.g. >> Debian GNU/kFreeBSD). > > Still present in: > > http://trillian.chruetertee.ch/ports/browser/trunk/x11-servers/xorg-server/files/extra-devd This seems correct to me. -- Eitan Adler