From owner-freebsd-stable@FreeBSD.ORG Mon Apr 22 05:14:54 2013 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 2004FD79 for ; Mon, 22 Apr 2013 05:14:54 +0000 (UTC) (envelope-from jdc@koitsu.org) Received: from qmta02.emeryville.ca.mail.comcast.net (qmta02.emeryville.ca.mail.comcast.net [IPv6:2001:558:fe2d:43:76:96:30:24]) by mx1.freebsd.org (Postfix) with ESMTP id 071F61095 for ; Mon, 22 Apr 2013 05:14:54 +0000 (UTC) Received: from omta05.emeryville.ca.mail.comcast.net ([76.96.30.43]) by qmta02.emeryville.ca.mail.comcast.net with comcast id St6L1l0040vp7WLA2tEt71; Mon, 22 Apr 2013 05:14:53 +0000 Received: from koitsu.strangled.net ([67.180.84.87]) by omta05.emeryville.ca.mail.comcast.net with comcast id StEt1l0011t3BNj8RtEthJ; Mon, 22 Apr 2013 05:14:53 +0000 Received: by icarus.home.lan (Postfix, from userid 1000) id 0169973A33; Sun, 21 Apr 2013 22:14:52 -0700 (PDT) Date: Sun, 21 Apr 2013 22:14:52 -0700 From: Jeremy Chadwick To: freebsd-stable@freebsd.org Subject: ada(4) and ahci(4) quirk printing Message-ID: <20130422051452.GA2148@icarus.home.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcast.net; s=q20121106; t=1366607693; bh=U8gEglnPrYiBBIMpx8dZoTPq+JetWM+gpFaaMHfGisc=; h=Received:Received:Received:Date:From:To:Subject:Message-ID: MIME-Version:Content-Type; b=kVcJZ5VYmWxi+rgoQUtCxEb3GNWJHsUzUE8GMsId2Alid3J6x6Rw507Na7KtO6WNd A00UdsCFW8wsg9ntfGw3bJ5SQ/PefVlYoqEi7w9Ade3yWX2wsomYeWIG/P3FEl0leh pDCnCZzKYTHHF6PFQm6ziqJTFQ/ltfoEazDF4bbPJZW1LEiv1yIEq/fzQZvvdK7Wsh HrRfiVvj4LDHG6KXGSvycD2nANVDlhQ3DfuB3Fh633O8XExbH7PbiidDkvfii6JvuQ j4kguNR75wlgN9q+bnLOYAVioE36ojfVm4xDgZpCUO2V/LNQe/YNJKjbkyaAv2lrD+ DhfYrI7ARvr9Q== Cc: Alexander Motin , Kenneth Merry X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Apr 2013 05:14:54 -0000 I've written the following patches and done the following testing (see the results.*.txt files): http://jdc.koitsu.org/freebsd/quirk_printing/ Important: these are against stable/9 r249715. Folks are welcome to try these; I've tested about as best as I can. Questions/comments for Alexander and Kenneth: 1. I'm not sure if the location of where I added the printf() code is correct or not, 2. Not sure if loader.conf(5) forced-quirks would show up here or not, 3. It would be nice to have the same for SCSI da(4). I took a stab at this but the printing code I wrote never got called (or the quirks entry I added wasn't right, not sure which), 4. I strongly believe quirk printing should be shown *without* verbose booting. I say this because I noticed some of the CAPAB printf()s only get shown if bootverbose is true. In fact, it's what prompted me to open PR 178040 ("My Intel 320 and 510-series SSDs don't show 4K quirks, yet advertise 512 logical and physical in IDENTIFY?! PR time!"). P.S. -- I know the printf() method with %b looks a weird, but it's easier than allocating some memory for a variable-length buffer and a case statement + strcat(), or risk calling printf() for each quirks repeatedly (re: interspersed kernel output). -- | Jeremy Chadwick jdc@koitsu.org | | UNIX Systems Administrator http://jdc.koitsu.org/ | | Mountain View, CA, US | | Making life hard for others since 1977. PGP 4BD6C0CB |