From owner-svn-src-head@FreeBSD.ORG  Mon Aug 24 22:05:48 2009
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id E9980106568D
	for <svn-src-head@freebsd.org>; Mon, 24 Aug 2009 22:05:48 +0000 (UTC)
	(envelope-from dougb@FreeBSD.org)
Received: from mail2.fluidhosting.com (mx21.fluidhosting.com [204.14.89.4])
	by mx1.freebsd.org (Postfix) with ESMTP id 7BD898FC27
	for <svn-src-head@freebsd.org>; Mon, 24 Aug 2009 22:05:48 +0000 (UTC)
Received: (qmail 8384 invoked by uid 399); 24 Aug 2009 22:05:46 -0000
Received: from localhost (HELO foreign.dougb.net)
	(dougb@dougbarton.us@127.0.0.1)
	by localhost with ESMTPAM; 24 Aug 2009 22:05:46 -0000
X-Originating-IP: 127.0.0.1
X-Sender: dougb@dougbarton.us
Message-ID: <4A930EB4.7080402@FreeBSD.org>
Date: Mon, 24 Aug 2009 15:05:40 -0700
From: Doug Barton <dougb@FreeBSD.org>
Organization: http://www.FreeBSD.org/
User-Agent: Thunderbird 2.0.0.23 (X11/20090822)
MIME-Version: 1.0
To: Christoph Mallon <christoph.mallon@gmx.de>
References: <200908231952.n7NJqlFg070672@svn.freebsd.org>
	<4A9231B7.9070204@gmx.de>
In-Reply-To: <4A9231B7.9070204@gmx.de>
X-Enigmail-Version: 0.96.0
OpenPGP: id=D5B2F0FB
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r196478 - head/etc
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 24 Aug 2009 22:05:49 -0000

Christoph Mallon wrote:
> Doug Barton schrieb:
>> Author: dougb
>> Date: Sun Aug 23 19:52:47 2009
>> New Revision: 196478
>> URL: http://svn.freebsd.org/changeset/base/196478
>>
>> Log:
>>   Prior to the dire warning about values of network_interfaces other than
>>   AUTO the biggest mistake users made was leaving lo0 off the list. Since
>>   lo0 is effectively mandatory, check for it and add it to the list if
>>   it's not there.
>>
>> Modified:
>>   head/etc/network.subr
>>
>> Modified: head/etc/network.subr
>> ==============================================================================
>>
>> --- head/etc/network.subr    Sun Aug 23 18:28:58 2009    (r196477)
>> +++ head/etc/network.subr    Sun Aug 23 19:52:47 2009    (r196478)
>> @@ -727,6 +727,13 @@ list_net_interfaces()
>>          ;;
>>      *)
>>          _tmplist="${network_interfaces} ${cloned_interfaces}"
>> +
>> +        # lo0 is effectively mandatory, so help prevent foot-shooting
>> +        #
>> +        case "$_tmplist" in
>> +        lo0*|*lo0|*' lo0 '*)    ;;    # This is fine, do nothing
> 
> Doesn't this also match malo0?
> IMO the test should be lo0|'lo0 '*|*' lo0'|*' lo0 '*.

Thank you for the suggestion, I've just committed it. :)


Doug

-- 

    This .signature sanitized for your protection