From owner-cvs-all@FreeBSD.ORG  Tue May 22 10:55:26 2007
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.org
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id C7CA216A41F;
	Tue, 22 May 2007 10:55:26 +0000 (UTC)
	(envelope-from rwatson@FreeBSD.org)
Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42])
	by mx1.freebsd.org (Postfix) with ESMTP id 901FB13C455;
	Tue, 22 May 2007 10:55:26 +0000 (UTC)
	(envelope-from rwatson@FreeBSD.org)
Received: from fledge.watson.org (fledge.watson.org [209.31.154.41])
	by cyrus.watson.org (Postfix) with ESMTP id 462EB472EB;
	Tue, 22 May 2007 06:55:26 -0400 (EDT)
Date: Tue, 22 May 2007 11:55:26 +0100 (BST)
From: Robert Watson <rwatson@FreeBSD.org>
X-X-Sender: robert@fledge.watson.org
To: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no>
In-Reply-To: <863b1pyw6e.fsf@dwp.des.no>
Message-ID: <20070522115320.C50138@fledge.watson.org>
References: <200705192051.l4JKp0rF074703@repoman.freebsd.org>
	<20070522003856.GX21795@elvis.mu.org>
	<20070522112825.U50138@fledge.watson.org>
	<863b1pyw6e.fsf@dwp.des.no>
MIME-Version: 1.0
Content-Type: MULTIPART/MIXED; BOUNDARY="0-73080879-1179831326=:50138"
Cc: cvs-src@FreeBSD.org, Alfred Perlstein <alfred@freebsd.org>,
	Andre Oppermann <andre@FreeBSD.org>, cvs-all@FreeBSD.org,
	src-committers@FreeBSD.org
Subject: Re: cvs commit: src/sys/kern uipc_syscalls.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 22 May 2007 10:55:26 -0000

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--0-73080879-1179831326=:50138
Content-Type: TEXT/PLAIN; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: QUOTED-PRINTABLE


On Tue, 22 May 2007, Dag-Erling Sm=F8rgrav wrote:

> Robert Watson <rwatson@FreeBSD.org> writes:
>> Alfred Perlstein <alfred@freebsd.org> writes:
>>> Is this the same bug that used to be in sendfile but got corrected some=
=20
>>> years back?
>> Dunno, but it sounds like we really need a comprehensive set of edge-cas=
e=20
>> tests for sendfile.
>
> This was not an edge case.  The edge case (no offset, no length, no heade=
r)=20
> was the one that worked; it was the non-trivial case (non-zero offset,=20
> explicit length, non-empty header) that was broken.  Nobody noticed becau=
se=20
> existing code (Apache, ftpd) only exercises the edge case.

I stand corrected. :-)

Robert N M Watson
Computer Laboratory
University of Cambridge
--0-73080879-1179831326=:50138--