From owner-dev-commits-doc-all@freebsd.org Tue Jul 27 15:36:05 2021 Return-Path: Delivered-To: dev-commits-doc-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id BAD9D661EDD for ; Tue, 27 Jul 2021 15:36:05 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4GZ1914DTxz4fJ3; Tue, 27 Jul 2021 15:36:05 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 78E8C5415; Tue, 27 Jul 2021 15:36:05 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 16RFa5kT076316; Tue, 27 Jul 2021 15:36:05 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 16RFa5iF076315; Tue, 27 Jul 2021 15:36:05 GMT (envelope-from git) Date: Tue, 27 Jul 2021 15:36:05 GMT Message-Id: <202107271536.16RFa5iF076315@gitrepo.freebsd.org> To: doc-committers@FreeBSD.org, dev-commits-doc-all@FreeBSD.org From: Ed Maste Subject: git: 05ace519fb - main - committers-guide: Place Differential Revision last in table MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: emaste X-Git-Repository: doc X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 05ace519fbd0dc1fa759245deeef75df8ccb951b Auto-Submitted: auto-generated X-BeenThere: dev-commits-doc-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the doc repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Jul 2021 15:36:05 -0000 The branch main has been updated by emaste (src committer): URL: https://cgit.FreeBSD.org/doc/commit/?id=05ace519fbd0dc1fa759245deeef75df8ccb951b commit 05ace519fbd0dc1fa759245deeef75df8ccb951b Author: Ed Maste AuthorDate: 2021-07-26 16:47:26 +0000 Commit: Ed Maste CommitDate: 2021-07-27 15:35:14 +0000 committers-guide: Place Differential Revision last in table Differential Revision must be the last line of the commit message. List it last in the table as well to help make this clear. Reviewed by: imp, ygy Approved by: ygy Differential Revision: https://reviews.freebsd.org/D31309 --- documentation/content/en/articles/committers-guide/_index.adoc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/documentation/content/en/articles/committers-guide/_index.adoc b/documentation/content/en/articles/committers-guide/_index.adoc index c0c5a4e559..83d4c490a9 100644 --- a/documentation/content/en/articles/committers-guide/_index.adoc +++ b/documentation/content/en/articles/committers-guide/_index.adoc @@ -2885,12 +2885,12 @@ Approved by: re (username) It should include the entire URL to the pull request, as these often act as code reviews for the code. For example: `https://github.com/freebsd/freebsd-src/pull/745` -|`Differential Revision:` -|The full URL of the Phabricator review. This line __must be the last line__. For example: `https://reviews.freebsd.org/D1708`. - |`Signed-off-by:` |ID certifies compliance with https://developercertificate.org/ +|`Differential Revision:` +|The full URL of the Phabricator review. This line __must be the last line__. For example: `https://reviews.freebsd.org/D1708`. + |=== .Commit Log for a Commit Based on a PR