From owner-freebsd-audit Thu Jun 7 12:48:22 2001 Delivered-To: freebsd-audit@freebsd.org Received: from mail.rpi.edu (mail.rpi.edu [128.113.22.40]) by hub.freebsd.org (Postfix) with ESMTP id C54AE37B401 for ; Thu, 7 Jun 2001 12:48:19 -0700 (PDT) (envelope-from drosih@rpi.edu) Received: from [128.113.24.47] (gilead.acs.rpi.edu [128.113.24.47]) by mail.rpi.edu (8.11.3/8.11.3) with ESMTP id f57JmDM89334; Thu, 7 Jun 2001 15:48:13 -0400 Mime-Version: 1.0 X-Sender: drosih@mail.rpi.edu Message-Id: In-Reply-To: References: Date: Thu, 7 Jun 2001 15:48:10 -0400 To: freebsd-print@bostonradio.org, freebsd-audit@FreeBSD.ORG From: Garance A Drosihn Subject: Re: Large Cleanup update for lpr & friends Content-Type: text/plain; charset="us-ascii" ; format="flowed" Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG At 6:08 PM -0400 6/3/01, Garance A Drosihn wrote: >The patch is about 2300 lines, so I think I'll post a >url instead of including the whole patch here. The >result is at: > >ftp://freefour.acs.rpi.edu/pub/bsdlpr/lpr-spruce.diff New version is at: ftp://freefour.acs.rpi.edu/pub/bsdlpr/lpr-spruce2.diff This DOES result in object-code changes for lpd.o on alpha (but not on i386). The problem is that the current code has a declaration of: static int sendfile __P((struct printer *pp, int type, char *file, int format)); but a routine definition of: static int sendfile(pp, type, file, format) struct printer *pp; int type; char *file; char format; /* <- note */ { ... } In ansi-fying this, I have to use 'int' or 'char' for both versions of 'format', and either choice will result in a change to the object code under Alpha. I think this is pretty much ready to go. Even if it could be more extensive, it's about as much as I want to tackle in a single pass. -- Garance Alistair Drosehn = gad@eclipse.acs.rpi.edu Senior Systems Programmer or gad@freebsd.org Rensselaer Polytechnic Institute or drosih@rpi.edu To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message