From owner-freebsd-hackers  Fri Aug 16  4:34:29 2002
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id AE3EF37B400; Fri, 16 Aug 2002 04:34:24 -0700 (PDT)
Received: from baraca.united.net.ua (ns.united.net.ua [193.111.8.193])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 8FF1643E6A; Fri, 16 Aug 2002 04:34:21 -0700 (PDT)
	(envelope-from max@vega.com)
Received: from vega.vega.com (xDSL-2-2.united.net.ua [193.111.9.226] (may be forged))
	by baraca.united.net.ua (8.11.6/8.11.6) with ESMTP id g7GBY4Z79168;
	Fri, 16 Aug 2002 14:34:07 +0300 (EEST)
	(envelope-from max@vega.com)
Received: from vega.vega.com (max@localhost [127.0.0.1])
	by vega.vega.com (8.12.5/8.11.3) with ESMTP id g7GBXvWe005227;
	Fri, 16 Aug 2002 14:33:57 +0300 (EEST)
	(envelope-from sobomax@FreeBSD.org)
Received: (from max@localhost)
	by vega.vega.com (8.12.5/8.12.5/Submit) id g7GBXnIX005225;
	Fri, 16 Aug 2002 14:33:49 +0300 (EEST)
From: Maxim Sobolev <max@vega.com>
Message-Id: <200208161133.g7GBXnIX005225@vega.vega.com>
Subject: Re: Increasing size of if_flags field in the ifnet structure [patch
To: ikostov@otel.net (Iasen Kostov)
Date: Fri, 16 Aug 2002 14:33:49 +0300 (EEST)
Cc: julian@elischer.org (Julian Elischer),
	sobomax@FreeBSD.ORG (Maxim Sobolev), hackers@FreeBSD.ORG,
	net@FreeBSD.ORG
In-Reply-To: <20020816131654.H18061-100000@shadowhand.OTEL.net> from "Iasen Kostov" at ΑΧΗ 16, 2002 
X-Mailer: ELM [version 2.5 PL5]
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: owner-freebsd-hackers@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-hackers.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-hackers>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-hackers>
X-Loop: FreeBSD.ORG

> 
>    Please take a look at this patch. It implement 1 more flag to if_flags
> and ofcourse it increases size of this flag field by using if_ipending
> which is unused.

There is no much point in this patch, because it will increase size of
struct  ifreq, which means that no ioctl's from older apps will be accepted
anyway. Therefore, there is no difference between those two, while my
approach is obviously cleaner.

-Maxim

> 
> On Thu, 15 Aug 2002, Julian Elischer wrote:
> 
> > you cannot break ABIs in 4.x
> > in 5.x it will probably be ok until (say) 5.1 or something.
> >
> >
> > On Thu, 15 Aug 2002, Maxim Sobolev wrote:
> >
> > > Folks,
> > >
> > > When implementing ability to switch interface into promisc mode using
> > > ifconfig(8) I've stumbled into the problem with already exhausted
> > > space in the `short if_flags' field in the ifnet structure. I need to
> > > allocate one new flag, while we already have 16 IFF_* flags, and even
> > > one additional flag which is implemented using currently free
> > > if_ipending field of the said structure. Attached patch is aimed at
> > > increasing size of if_flags to 32 bits, as well as to clean-up
> > > if_ipending abuse. Granted, it will break backward ABI compatibility,
> > > but IMO it is not a big problem.
> > >
> > > Comments and suggestions are greatly appreciated. Thanks!
> > >
> > > -Maxim
> >
> >
> > To Unsubscribe: send mail to majordomo@FreeBSD.org
> > with "unsubscribe freebsd-net" in the body of the message
> >
> 


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-hackers" in the body of the message