From owner-cvs-all  Tue Sep 19 22:42:47 2000
Delivered-To: cvs-all@freebsd.org
Received: from critter.freebsd.dk (flutter.freebsd.dk [212.242.40.147])
	by hub.freebsd.org (Postfix) with ESMTP
	id 901D937B422; Tue, 19 Sep 2000 22:42:42 -0700 (PDT)
Received: from critter (localhost [127.0.0.1])
	by critter.freebsd.dk (8.11.0/8.9.3) with ESMTP id e8K5gfN94349;
	Wed, 20 Sep 2000 07:42:41 +0200 (CEST)
	(envelope-from phk@critter.freebsd.dk)
To: Brian Somers <brian@FreeBSD.org>
Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/lib/libc/stdlib malloc.c setenv.c 
In-Reply-To: Your message of "Tue, 19 Sep 2000 20:05:38 PDT."
             <200009200305.UAA32271@freefall.freebsd.org> 
Date: Wed, 20 Sep 2000 07:42:40 +0200
Message-ID: <94347.969428560@critter>
From: Poul-Henning Kamp <phk@critter.freebsd.dk>
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

In message <200009200305.UAA32271@freefall.freebsd.org>, Brian Somers writes:
>brian       2000/09/19 20:05:38 PDT
>
>  Modified files:
>    lib/libc/stdlib      malloc.c setenv.c 
>  Log:
>  Only realloc() environ if we're sure that we know where it came from.
>  
>  The recent problems with sshd were due to sshd reassigning
>  `environ' when setenv() thinks it owns it.  setenv() subsequently
>  realloc()s the new version of environ and *boom*

Uhm, Brian ?  Could you please remove EXTRA_SANITY in malloc.c again ?

--
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD coreteam member | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message