Date: Tue, 12 Dec 2000 17:51:53 +0200 (EET) From: Giorgos Keramidas <keramida@westgate.gr> To: FreeBSD-gnats-submit@freebsd.org Subject: ports/23504: small stylistic fix for editors/emacs20 port Message-ID: <200012121551.eBCFprK26718@gray.westgate.gr> Resent-Message-ID: <200012121600.eBCG02O48830@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 23504
>Category: ports
>Synopsis: Small stylistic fix in ports/editors/emacs20
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Tue Dec 12 08:00:01 PST 2000
>Closed-Date:
>Last-Modified:
>Originator: Giorgos Keramidas
>Release: FreeBSD 4.2-STABLE i386
>Organization:
CTI
>Environment:
Ports tree CVSup'ed a few minutes ago.
>Description:
The Makefile of ports/editors/emacs20 contains the following
interesting piece of code:
.if !defined(WITHOUT_X11)
CONFIGURE_ARGS= --with-x-toolkit --with-pop
USE_XLIB= yes
.else
CONFIGURE_ARGS= --with-x=no --with-pop
.endif
Watch how the double negative in that .if might cause someone
wonder "What? Do I have to `set' or `unset' the WITHOUT_X11
variable to compile this without X support? Which one is it?"
>How-To-Repeat:
Heh. Read the Makefile ?
>Fix:
I would prefer this being written with the double negative
removed. Something like:
.if defined(WITHOUT_X11)
CONFIGURE_ARGS= --with-x=no --with-pop
.else
CONFIGURE_ARGS= --with-x-toolkit --with-pop
USE_XLIB= yes
.endif
Then again, this is a minor stylistic change :)
>Release-Note:
>Audit-Trail:
>Unformatted:
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200012121551.eBCFprK26718>